branch: externals/tmr
commit 396f70e9f4402bf9de078bf3844ad4a5a6a63ff2
Author: Protesilaos Stavrou <i...@protesilaos.com>
Commit: Protesilaos Stavrou <i...@protesilaos.com>
Tweak how the ffplay process is called
This is in response to issue 8 by Mirko Hernandez:
<https://github.com/protesilaos/tmr/issues/8>. We will consider how to
make this customisable.
---
README.org | 2 +-
tmr.el | 5 ++---
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/README.org b/README.org
index 4fb4cfc8be..cca6d87ba7 100644
--- a/README.org
+++ b/README.org
@@ -465,7 +465,7 @@ TMR is meant to be a collective effort. Every bit of help
matters.
Mendler, Steven Allen.
+ Contributions to the code or manual :: Christian Tietze, Ed Tavinor,
- Nathan R. DeGruchy.
+ Mirko Hernandez, Nathan R. DeGruchy.
* GNU Free Documentation License
:PROPERTIES:
diff --git a/tmr.el b/tmr.el
index e9454991a7..1fb0e8c403 100644
--- a/tmr.el
+++ b/tmr.el
@@ -551,12 +551,11 @@ Read Info node `(elisp) Desktop Notifications' for
details."
(defun tmr-sound-play (&optional _timer)
"Play `tmr-sound-file' using the ffplay executable (ffmpeg).
TIMER is unused."
- (when-let* ((sound tmr-sound-file)
+ (when-let* ((sound (expand-file-name tmr-sound-file))
((file-exists-p sound)))
(unless (executable-find "ffplay")
(user-error "Cannot play %s without `ffplay'" sound))
- (call-process-shell-command
- (format "ffplay -nodisp -autoexit %s >/dev/null 2>&1" sound) nil 0)))
+ (call-process "ffplay" nil 0 nil "-nodisp" "-autoexit" sound)))
(defun tmr-print-message-for-created-timer (timer)
"Show a `message' informing the user that TIMER was created."
