branch: externals/spacious-padding commit 342aeabe0a7e6e0cab75c8f078cd8569f8c3fccb Author: Protesilaos Stavrou <i...@protesilaos.com> Commit: Protesilaos Stavrou <i...@protesilaos.com>
Mention x-underline-at-descent-line for Emacs 28 users --- README.org | 4 ++++ spacious-padding.el | 6 +++++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/README.org b/README.org index a6ee2a36e9..9d15457fe1 100644 --- a/README.org +++ b/README.org @@ -209,6 +209,10 @@ which can be used as described above. [ These faces are the new names of the now-obsolete ~spacious-padding-subtle-mode-line-active~ and ~spacious-padding-subtle-mode-line-inactive~ as part of {{{development-version}}}. ] +Users of Emacs 28 need to set ~x-underline-at-descent-line~ to a non-nil +value to get the desired spacing with the underlines. Newer versions of +Emacs give us control of this attribute at the level of the individual face. + * Installation :PROPERTIES: :CUSTOM_ID: h:f3bdac2c-4704-4a51-948c-a789a2589790 diff --git a/spacious-padding.el b/spacious-padding.el index 6d8e368ad4..57ce77fedb 100644 --- a/spacious-padding.el +++ b/spacious-padding.el @@ -234,7 +234,11 @@ which can be used as described above. Another example: \\='( :mode-line-active spacious-padding-line-active :mode-line-inactive spacious-padding-line-inactive :header-line-active spacious-padding-line-active - :header-line-inactive spacious-padding-line-inactive))" + :header-line-inactive spacious-padding-line-inactive)) + +Users of Emacs 28 need to set `x-underline-at-descent-line' to a non-nil +value to get the desired spacing with the underlines. Newer versions of +Emacs give us control of this attribute at the level of the individual face." :type '(choice boolean (plist :key-type (choice (const :mode-line-active)