branch: externals/denote commit a419ce1c4706764eb3254a974f2df3d79df70695 Author: Protesilaos Stavrou <i...@protesilaos.com> Commit: Protesilaos Stavrou <i...@protesilaos.com>
Revert "Fix denote--dir-in-denote-directory-p" This reverts commit 6dd9a135b7191ed92688e6fc3ae04edb5c4c9eb4. What I did is wrong because now a subdirectory will never satisfy this condition. Thanks to oatmealm for reporting the bug in issue 620: <https://github.com/protesilaos/denote/issues/620>. --- README.org | 5 +++-- denote.el | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/README.org b/README.org index b2fc3b181b..6f566656f9 100644 --- a/README.org +++ b/README.org @@ -6441,8 +6441,9 @@ Denote is meant to be a collective effort. Every bit of help matters. Mealing, Wilf, Yi Liu, Ypot, atanasj, azegas, babusri, bdillahu, coherentstate, doolio, duli, drcxd, elge70, elliottw, fingerknight, hpgisler, hyperfocus1337,johkneisl, jtpavlock, juh, leafarbelm, - mentalisttraceur, mjkalyan, pRot0ta1p, rbenit68, relict007, - sarcom-sar, sienic, skissue, sundar bp, yetanotherfossman, zadca123 + mentalisttraceur, mjkalyan, oatmealm, pRot0ta1p, rbenit68, + relict007, sarcom-sar, sienic, skissue, sundar bp, + yetanotherfossman, zadca123 Special thanks to Peter Povinec who helped refine the file-naming scheme, which is the cornerstone of this project. diff --git a/denote.el b/denote.el index aed7d85e03..c9bab78cd7 100644 --- a/denote.el +++ b/denote.el @@ -2782,7 +2782,7 @@ TEMPLATE, and SIGNATURE should be valid for note creation." "Return non-nil if DIRECTORY is in variable `denote-directory'." (seq-some (lambda (d) - (string-prefix-p (expand-file-name directory) d)) + (string-prefix-p d (expand-file-name directory))) (denote-directories))) (defun denote--valid-file-type (filetype)