branch: externals/transient
commit 51915436f76ff262766d40bee3c84dfe3568d289
Author: Jonas Bernoulli <jo...@bernoul.li>
Commit: Jonas Bernoulli <jo...@bernoul.li>
transient--resume-override: No longer call transient--show
It is unnecessary to call `transient--show' here because it will
later happen anyway when `transient--post-command' calls either
`transient--refresh-transient' or `transient--redisplay'.
Calling `transient--show' here also meant that it could not take any
state changes into account that the invoked command made, which is
relevant if `refresh-suffixes' is non-nil and those changes effect
the result of, e.g., suffix predicates.
Closes #397.
---
lisp/transient.el | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/lisp/transient.el b/lisp/transient.el
index 3e72990b6c..2f5ad0c257 100644
--- a/lisp/transient.el
+++ b/lisp/transient.el
@@ -2758,10 +2758,8 @@ value. Otherwise return CHILDREN as is.")
(defun transient--resume-override (&optional _ignore)
(transient--debug 'resume-override)
- (cond ((and transient--showp (not (window-live-p transient--window)))
- (transient--show))
- ((window-live-p transient--window)
- (transient--fit-window-to-buffer transient--window)))
+ (when (window-live-p transient--window)
+ (transient--fit-window-to-buffer transient--window))
(transient--push-keymap 'transient--transient-map)
(transient--push-keymap 'transient--redisplay-map)
(add-hook 'pre-command-hook #'transient--pre-command)
