branch: externals/dired-preview
commit bfbd66d95c47c99b601c0b31d165c1e35ac5993b
Author: Protesilaos Stavrou <i...@protesilaos.com>
Commit: Protesilaos Stavrou <i...@protesilaos.com>
Make sure page up command operates in the preview window
Thanks to Alex Popescu for telling me that the command does not work,
which led me to discover the missing use of the 'dired-preview-with-window'
macro. This was done in issue 28:
<https://github.com/protesilaos/dired-preview/issues/28>.
---
README.org | 6 +++---
dired-preview.el | 7 ++++---
2 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/README.org b/README.org
index af42cd1135..c85f6996ba 100644
--- a/README.org
+++ b/README.org
@@ -365,9 +365,9 @@ matters.
Bruno Boal, Christian Tietze, Juergen Hoetzel, Karthik Chikmagalur,
Sean Devlin, Stefan Monnier, Philip Kaludercic, Nofint.
-+ Ideas and/or user feedback :: Bruno Boal, Ed Hamilton, Karthik
- Chikmagalur, Peter Prevos, Ramon Diaz-Uriarte, Yiyu Zhou, artelse,
- fab6, Inkbottle00.
++ Ideas and/or user feedback :: Alex Popescu, Bruno Boal, Ed Hamilton,
+ Karthik Chikmagalur, Peter Prevos, Ramon Diaz-Uriarte, Yiyu Zhou,
+ artelse, fab6, Inkbottle00.
* GNU Free Documentation License
:PROPERTIES:
diff --git a/dired-preview.el b/dired-preview.el
index a648555923..d874ae1088 100644
--- a/dired-preview.el
+++ b/dired-preview.el
@@ -5,7 +5,7 @@
;; Author: Protesilaos Stavrou <i...@protesilaos.com>
;; Maintainer: Protesilaos Stavrou <i...@protesilaos.com>
;; URL: https://github.com/protesilaos/dired-preview
-;; Version: 0.5.0
+;; Version: 0.5.1
;; Package-Requires: ((emacs "28.1"))
;; Keywords: files, convenience
@@ -479,11 +479,12 @@ This technically runs `scroll-up-command'."
"Move a page up in the preview window.
This technically runs `scroll-down-command'."
(interactive)
- (call-interactively
+ (dired-preview-with-window
+ (call-interactively
(pcase (derived-mode-p major-mode)
('doc-view-mode 'doc-view-scroll-down-or-previous-page)
('pdf-view-mode 'pdf-view-scroll-down-or-previous-page)
- (_ 'scroll-down-command))))
+ (_ 'scroll-down-command)))))
(declare-function hexl-mode "hexl")
(declare-function hexl-mode-exit "hexl" (&optional arg))
