branch: scratch/logview
commit 4dfa974856278e15f933e75b907e1646eeb2e57c
Author: Stefan Monnier <monn...@iro.umontreal.ca>
Commit: Stefan Monnier <monn...@iro.umontreal.ca>
(logview-filter-edit--do): Hoist `setf` out of `if`
---
logview.el | 15 ++++++++-------
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/logview.el b/logview.el
index 4ebb1a4310..0c328a9cd8 100644
--- a/logview.el
+++ b/logview.el
@@ -4352,13 +4352,14 @@ only edits after it get discarded."
(let ((new-views (save-excursion
(goto-char (point-min))
(logview--parse-view-definitions t))))
- (if logview-filter-edit--editing-views-for-submode
- (let ((combined-views (nreverse new-views)))
- (dolist (view (logview--views))
- (unless (equal (plist-get view :submode)
logview-filter-edit--editing-views-for-submode)
- (push view combined-views)))
- (setf logview--views (nreverse combined-views)))
- (setf logview--views new-views))
+ (setf logview--views
+ (if logview-filter-edit--editing-views-for-submode
+ (let ((combined-views (nreverse new-views)))
+ (dolist (view (logview--views))
+ (unless (equal (plist-get view :submode)
logview-filter-edit--editing-views-for-submode)
+ (push view combined-views)))
+ (nreverse combined-views))
+ new-views))
(setf logview--views-need-saving t)
(logview--after-updating-view-definitions)
(with-current-buffer parent
