branch: externals/transient
commit 3cd02ec21cedb70ce1ed8e87b6c5cf1557a59cbe
Author: Jonas Bernoulli <jo...@bernoul.li>
Commit: Jonas Bernoulli <jo...@bernoul.li>

    transient--suspend-override: Assert transient--window is still live
    
    It should be, but something else might mess with it.
    
    Helm's completing-read function does mess with it.  It *appears*
    (I haven't investigated further) that it tries to use our window,
    but because we prevent that, it instead deletes that window and
    creates its own window.  It does however bring back our buffer,
    when done.  Still, we cannot assume here that our window is live.
    
    Closes the second coming of #656.
---
 lisp/transient.el | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lisp/transient.el b/lisp/transient.el
index 3032f7c6e2..7610b3e43e 100644
--- a/lisp/transient.el
+++ b/lisp/transient.el
@@ -2604,6 +2604,7 @@ value.  Otherwise return CHILDREN as is.")
   (transient--timer-cancel)
   (let ((show (if nohide 'fixed transient-show-during-minibuffer-read)))
     (when (and (integerp show)
+               (window-live-p transient--window)
                (< (frame-height (window-frame transient--window))
                   (+ (abs show)
                      (window-height transient--window))))

Reply via email to