branch: externals/colorful-mode
commit b75b20f803cb9774c7f5ac0e69a1104206d9603f
Author: Elías Gabriel Pérez <eg642...@gmail.com>
Commit: Elías Gabriel Pérez <eg642...@gmail.com>

    Allow disabling colorful on buffers which can break them
    
    Create new user option for disable colorful in specified buffers,
    such as buffers derived from help-mode
    
    * colorful-mode.el (colorful-excluded-buffers): New user option.
    (colorful-mode): Changes.
---
 colorful-mode.el | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/colorful-mode.el b/colorful-mode.el
index 18521b2f67..8c6637d139 100644
--- a/colorful-mode.el
+++ b/colorful-mode.el
@@ -368,6 +368,12 @@ Only relevant if `colorful-use-prefix' is non-nil."
   "List of keyword to don't highlight."
   :type '(repeat string))
 
+(defcustom colorful-excluded-buffers '("*Faces*" "*Colors*")
+  "Do not activate colorful in these buffers.
+In case colorful breaks a buffer, such as a buffer
+derived from `help-mode', this option can be useful for you."
+  :type '(repeat string))
+
 (defcustom colorful-short-hex-conversions t
   "If non-nil, hex values converted by colorful should be as short as possible.
 Setting this to non-nil will make hex values follow a 24-bit
@@ -936,6 +942,7 @@ This is intended to be used with 
`colorful-extra-color-keyword-functions'."
 (defun colorful--turn-on ()
   "Helper function for turn on `colorful-mode'."
   ;; Run functions from list for add keywords to `colorful-color-keywords'.
+  ;; TODO: Use cl-loop instead this weird dolist.
   (dolist (fn colorful-extra-color-keyword-functions)
     (cond
      ((and (listp fn)
@@ -973,8 +980,7 @@ This is intended to be used with 
`colorful-extra-color-keyword-functions'."
   "Preview any color in your buffer such as hex, color names, CSS rgb in real 
time."
   :global nil
   ;; Do not activate it in these buffers.
-  (unless (or (string= (buffer-name) "*Faces*")
-              (string= (buffer-name) "*Colors*"))
+  (unless (member (buffer-name) colorful-excluded-buffers)
     (if colorful-mode
         (colorful--turn-on)
       (colorful--turn-off))

Reply via email to