branch: externals/ellama
commit 67f5aac3b8ddfd3409fdb3c2a473c5ec8adaa9a0
Author: Sergey Kostyaev <sskosty...@gmail.com>
Commit: Sergey Kostyaev <sskosty...@gmail.com>
Refactor file name fixing logic
Refactored `ellama--fix-file-name` function to use a predefined
constant `ellama--bad-file-name-characters` for forbidden characters,
improving readability and maintainability. Also improve regexp
efficiency based on code review.
---
ellama.el | 21 ++++++---------------
1 file changed, 6 insertions(+), 15 deletions(-)
diff --git a/ellama.el b/ellama.el
index 00e3c0cf6b..ae90761246 100644
--- a/ellama.el
+++ b/ellama.el
@@ -647,23 +647,14 @@ EXTRA contains additional information."
"Return ellama session buffer by provided ID."
(gethash id ellama--active-sessions))
+(defconst ellama--forbidden-file-name-characters (rx (any "/\\?%*:|\"<>.;=")))
+
(defun ellama--fix-file-name (name)
"Change forbidden characters in the NAME to acceptable."
- (replace-regexp-in-string (rx (or (literal "/")
- (literal "\\")
- (literal "?")
- (literal "%")
- (literal "*")
- (literal ":")
- (literal "|")
- (literal "\"")
- (literal "<")
- (literal ">")
- (literal ".")
- (literal ";")
- (literal "=")))
- "_"
- name))
+ (replace-regexp-in-string
+ ellama--forbidden-file-name-characters
+ "_"
+ name))
(defun ellama-generate-name-by-words (provider action prompt)
"Generate name for ACTION by PROVIDER by getting first N words from PROMPT."
