branch: externals/auth-source-xoauth2-plugin commit c0e9c431e17a6d7c359685382f29fe2fa5d3ba50 Author: Xiyue Deng <manp...@gmail.com> Commit: Xiyue Deng <manp...@gmail.com>
Don't rely on the side effect of plist-put * Use setq to reassign the plist. (Based on review at https://debbugs.gnu.org/cgi/bugreport.cgi?bug=72992#14. Thanks Philip Kaludercic for the review and suggestions!) --- auth-source-xoauth2-plugin.el | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/auth-source-xoauth2-plugin.el b/auth-source-xoauth2-plugin.el index 8a4e6ec990..42530ec108 100644 --- a/auth-source-xoauth2-plugin.el +++ b/auth-source-xoauth2-plugin.el @@ -117,7 +117,8 @@ set along `host', `user', and `port' (note the snake_case)." (let ((access-token (oauth2-token-access-token token))) (auth-source-do-trivia "Updating :secret with access-token: %s" access-token) - (plist-put auth-data :secret access-token)))))) + (setq auth-data + (plist-put auth-data :secret access-token))))))) (unless (and check-secret (not (plist-get auth-data :secret)))