branch: externals/org-transclusion commit bb552d2c38c1d8eaa23c2a4bc2e8b3970a219a8c Author: Noboru Ota <m...@nobiot.com> Commit: Noboru Ota <m...@nobiot.com>
chg: apply patch for Makefile by S. Monnier (2024-11-13) Date: Wed, 13 Nov 2024 16:29:04 -0500 I was seeing `org-transclusion.org` rebuilt all the time in my local checkout until I finally understood that your Makefile rule isn't quite right. It says: org-transclusion.org: docs/org-transclusion-manual.org -emacs --batch -L "$$(pwd)" -l org-transclusion $< \ --eval '(progn (org-transclusion-add-all) (write-region nil nil "org-transclusion.org"))' but it doesn't build `./org-transclusion.org`. Instead the `write-region` saves the result into `docs/org-transclusion.org` because it's called from the `docs/org-transclusion-manual.org` buffer, hence from the `docs` subdirectory. So I suggest the patch below. Stefan --- .gitignore | 4 ++++ Makefile | 2 +- org-transclusion.el | 2 +- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/.gitignore b/.gitignore index f907e4333f..cc9739232e 100644 --- a/.gitignore +++ b/.gitignore @@ -1,3 +1,7 @@ test/ refile/ *.elc + +# ELPA-generated files. +/org-transclusion-autoloads.el +/org-transclusion-pkg.el diff --git a/Makefile b/Makefile index 3721b40a70..a96216d2df 100644 --- a/Makefile +++ b/Makefile @@ -1,4 +1,4 @@ -org-transclusion.org: docs/org-transclusion-manual.org +docs/org-transclusion.org: docs/org-transclusion-manual.org -emacs --batch -L "$$(pwd)" -l org-transclusion $< \ --eval '(progn (org-transclusion-add-all) (write-region nil nil "org-transclusion.org"))' diff --git a/org-transclusion.el b/org-transclusion.el index 6c83a1c50e..505cd66b6a 100644 --- a/org-transclusion.el +++ b/org-transclusion.el @@ -103,7 +103,7 @@ See `display-buffer' for example options." " OT" "Mode-line indicator for minor-mode variable `org-transclusion-mode'." :type '(choice (const :tag "No lighter" "") string) - :safe 'stringp) + :safe #'stringp) (defcustom org-transclusion-after-add-functions nil "Functions to be called after a transclusion content has been added.