branch: elpa/dslide commit 4209916697c74f196be6834edfa01a25da597444 Author: Psionik K <73710933+psioni...@users.noreply.github.com> Commit: Psionik K <73710933+psioni...@users.noreply.github.com>
Off-by-one bug in markup hiding code This was causing images with associated keywords to be hidden unless they were preceded by a space, as seen in the demo. It is unknown what forces of evil compelled me to include the extraneous space before images in the demo. Likely I encountered the issue while recording and made it work, intending to double back and fix it before not understanding that there was an issue when looking at my todo list. Evil thrives in entropy and can succeed at its nefarious goals even when it is miniscule and even while good appears overwhelming. --- dslide.el | 2 +- test/demo.org | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/dslide.el b/dslide.el index 8a0326cdb4..3d9b1d150d 100644 --- a/dslide.el +++ b/dslide.el @@ -1218,7 +1218,7 @@ for `dslide-contents-map'.") (goto-char (oref obj begin)) (while (re-search-forward org-keyword-regexp bound t) (let ((overlay (make-overlay (match-beginning 0) - (1+ (match-end 0))))) + (match-end 0)))) (overlay-put overlay 'invisible t) (push dslide-overlays overlay))))))) diff --git a/test/demo.org b/test/demo.org index 027a911f09..703cc45056 100644 --- a/test/demo.org +++ b/test/demo.org @@ -113,9 +113,9 @@ Positron is deeply committed to bringing you the finest in: - The image buffer is configured to act as a slide, so it still responds to the keybindings. - See more options, such as fullscreen etc by calling ~describe-symbol~ on ~dslide-action-image~ #+ATTR_HTML: :width 45% - [[./images/emacsen4.jpeg]] [[./images/self-care5.jpeg]] +[[./images/emacsen4.jpeg]] [[./images/self-care5.jpeg]] #+ATTR_HTML: :width 45% - [[./images/before-google3.jpeg]] [[./images/all-software-is-the-same-with-tang.jpeg]] +[[./images/before-google3.jpeg]] [[./images/all-software-is-the-same-with-tang.jpeg]] * No Header Slide :PROPERTIES: :DSLIDE_SLIDE_ACTION: dslide-slide-action-child :header nil