branch: externals-release/ement
commit 83a73d1001110455889066ab7119c973a73dbb87
Author: Adam Porter <a...@alphapapa.net>
Commit: Adam Porter <a...@alphapapa.net>
Fix: (magit-section-ident-value ement-room-list-section)
Emacs 27 doesn't support the same use of `cl-type' in `pcase'.
Fixes #272.
Reported-by: Phil Sainty <p...@catalyst.net.nz>
---
ement-room-list.el | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/ement-room-list.el b/ement-room-list.el
index 603803660c..8a9c4f28e3 100644
--- a/ement-room-list.el
+++ b/ement-room-list.el
@@ -66,12 +66,16 @@ a symbol, it should be unquoted.."
nil)
(cl-defmethod magit-section-ident-value ((section ement-room-list-section))
+ "Return ident value for `ement-room-list-section' SECTION.
+Used for caching section visibility."
;; FIXME: The name of each taxy could be ambiguous. Best would be to use the
;; hierarchical path, but since the taxys aren't doubly linked, that isn't
easily done.
;; Could probably be worked around by binding a special variable around the
creation of
;; the taxy hierarchy that would allow the path to be saved into each taxy.
(pcase-exhaustive (oref section value)
- ((and (cl-type taxy-magit-section) it)
+ ;; FIXME(emacs-28): Use `(cl-type taxy-magit-section)' when requiring
Emacs 28. See
+ ;; <https://github.com/alphapapa/ement.el/issues/272>.
+ ((and (pred taxy-magit-section-p) it)
(taxy-name it))
(`[,(and (cl-type ement-room) room)
,(and (cl-type ement-session) session)]
