branch: externals/activities
commit 974eb815c580088e2f8081b45f441e33709faf75
Author: Adam Porter <a...@alphapapa.net>
Commit: Adam Porter <a...@alphapapa.net>
Change: Rename tabs face to activites-tabs and inherit
Closes #24.
Suggested-by: Karthik Chikmagalur <https://github.com/karthink>
---
README.org | 1 +
activities-tabs.el | 9 +++++----
activities.info | 51 ++++++++++++++++++++++++++++-----------------------
3 files changed, 34 insertions(+), 27 deletions(-)
diff --git a/README.org b/README.org
index 965f01d2ed..1c07265e92 100644
--- a/README.org
+++ b/README.org
@@ -140,6 +140,7 @@ When option ~activities-bookmark-store~ is enabled, an
Emacs bookmark is stored
*Changes*
+ Command ~activities-kill~ now discards an activity's last state (while
~activities-suspend~ saves its last state), and closes its frame or tab.
++ Face ~activities-tabs-face~ is renamed to ~activities-tabs~, and now
inherits from another face by default, which allows it to adjust with the
loaded theme. ([[https://github.com/alphapapa/activities.el/issues/24][#24]].
Thanks to [[https://github.com/karthink][Karthik Chikmagalur]] for suggesting.)
*Fixes*
+ Show a helpful error if a bookmark's target file is missing.
([[https://github.com/alphapapa/activities.el/issues/17][#17]]. Thanks to
[[https://github.com/jdtsmith][JD Smith]] for reporting.)
diff --git a/activities-tabs.el b/activities-tabs.el
index 9cc8f17ed8..8e02fc62a0 100644
--- a/activities-tabs.el
+++ b/activities-tabs.el
@@ -50,8 +50,8 @@ Each is called with one argument, the activity."
"Prepended to activity names in tabs."
:type 'string)
-(defface activities-tabs-face
- `((t :foreground ,(face-foreground 'font-lock-function-name-face nil
'default)))
+(defface activities-tabs
+ `((t :inherit font-lock-function-name-face))
"Applied to tab-bar faces for tabs representing activities.")
;;;; Mode
@@ -126,11 +126,12 @@ Selects its tab, making one if needed. Its state is not
changed."
(defun activities-tabs--tab-bar-tab-face-function (tab)
"Return a face for TAB.
-If TAB represents an activity, `activities-tabs-face' is added."
+If TAB represents an activity, face `activities-tabs' is added as
+inherited."
;; TODO: Propose a tab-bar equivalent of `tab-line-tab-face-functions'.
(let ((face (funcall activities-tabs-tab-bar-tab-face-function-original
tab)))
(if (activities-tabs--tab-parameter 'activity tab)
- `(:inherit (activities-tabs-face ,face))
+ `(:inherit (activities-tabs ,face))
face)))
(defun activities-tabs-activity--set (activity)
diff --git a/activities.info b/activities.info
index c36e06688c..4d32415370 100644
--- a/activities.info
+++ b/activities.info
@@ -397,6 +397,11 @@ File: README.info, Node: v05-pre, Next: v04, Up:
Changelog
• Command ‘activities-kill’ now discards an activity’s last state
(while ‘activities-suspend’ saves its last state), and closes its
frame or tab.
+ • Face ‘activities-tabs-face’ is renamed to ‘activities-tabs’, and
+ now inherits from another face by default, which allows it to
+ adjust with the loaded theme. (#24
+ (https://github.com/alphapapa/activities.el/issues/24). Thanks to
+ Karthik Chikmagalur (https://github.com/karthink) for suggesting.)
*Fixes*
• Show a helpful error if a bookmark’s target file is missing. (#17
@@ -556,29 +561,29 @@ Node: Installation2471
Node: GNU ELPA2622
Node: Quelpa2987
Node: Configuration3707
-Node: Usage4545
-Node: Activities4747
-Node: Compatibility5735
-Node: Modes6219
-Node: Workflow6887
-Node: Bindings7840
-Node: Commands8486
-Node: Bookmarks9935
-Node: FAQ10287
-Node: Changelog13363
-Node: v05-pre13648
-Node: v0414186
-Node: v03314731
-Node: v03215161
-Node: v03115289
-Node: v0315619
-Node: v0216009
-Node: v01316501
-Node: v01216650
-Node: v01116827
-Node: v0116992
-Node: Development17093
-Node: Copyright assignment17365
+Node: Usage4663
+Node: Activities4865
+Node: Compatibility5853
+Node: Modes6337
+Node: Workflow7005
+Node: Bindings7958
+Node: Commands8604
+Node: Bookmarks10053
+Node: FAQ10405
+Node: Changelog13481
+Node: v05-pre13766
+Node: v0414636
+Node: v03315181
+Node: v03215611
+Node: v03115739
+Node: v0316069
+Node: v0216459
+Node: v01316951
+Node: v01217100
+Node: v01117277
+Node: v0117442
+Node: Development17543
+Node: Copyright assignment17815
End Tag Table
