branch: externals/org commit 8b35734b49bd07cd9a3b3b1b37c4bc1288ba42f8 Author: Ihor Radchenko <yanta...@posteo.net> Commit: Ihor Radchenko <yanta...@posteo.net>
test-org-colview/...: Fix Emacs 28 compatibility * testing/lisp/test-org-colview.el (test-org-colview/columns--move-row-stay-at-the-same-column): Skip the test in Emacs <29 where it is not possible to determine visual column. --- testing/lisp/test-org-colview.el | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/testing/lisp/test-org-colview.el b/testing/lisp/test-org-colview.el index 37bc0a0b5e..02b84eecb5 100644 --- a/testing/lisp/test-org-colview.el +++ b/testing/lisp/test-org-colview.el @@ -1127,17 +1127,19 @@ (ert-deftest test-org-colview/columns--move-row-stay-at-the-same-column () "After function call 'org-columns--move-row' point should stay at the same column." + ;; `current-column' did not return _visual_ column prior to Emacs 29. + (skip-unless (version>= emacs-version "29")) (should (equal 35 - (org-test-with-temp-text "* H + (org-test-with-temp-text "* H ** A ** B " - (org-columns) - (next-line 1) - (forward-char 2) - (org-columns--move-row) - (current-column))))) + (org-columns) + (next-line 1) + (forward-char 2) + (org-columns--move-row) + (current-column))))) (ert-deftest test-org-colview/columns-move-row-down-with-subheading () "Test `org-columns-move-row-up' specifications with subheading."