branch: elpa/cider commit 00f765b80014c55f81d7600ce945d6b4216a6d25 Author: vemv <v...@users.noreply.github.com> Commit: Bozhidar Batsov <bozhi...@batsov.dev>
Add a standard header suggesting `it` blocks --- test/cider-apropos-tests.el | 2 ++ test/cider-browse-ns-tests.el | 2 ++ test/cider-browse-spec-tests.el | 2 ++ test/cider-classpath-tests.el | 2 ++ test/cider-client-tests.el | 2 ++ test/cider-clojuredocs-tests.el | 2 ++ test/cider-common-tests.el | 2 ++ test/cider-connection-tests.el | 2 ++ test/cider-debug-tests.el | 2 ++ test/cider-doc-tests.el | 2 ++ test/cider-eldoc-tests.el | 2 ++ test/cider-error-parsing-tests.el | 2 ++ test/cider-eval-tests.el | 2 ++ test/cider-find-tests.el | 2 ++ test/cider-font-lock-tests.el | 1 + test/cider-interaction-tests.el | 2 ++ test/cider-jar-tests.el | 2 ++ test/cider-locals-tests.el | 2 ++ test/cider-log-tests.el | 2 ++ test/cider-ns-tests.el | 2 ++ test/cider-overlay-tests.el | 2 ++ test/cider-repl-tests.el | 2 ++ test/cider-selector-tests.el | 2 ++ test/cider-stacktrace-tests.el | 2 ++ test/cider-test-tests.el | 2 ++ test/cider-tests--no-auto.el | 2 ++ test/cider-tests.el | 2 ++ test/cider-util-tests.el | 2 ++ test/integration/integration-tests.el | 3 ++- test/nrepl-bencode-tests.el | 2 ++ test/nrepl-client-tests.el | 2 ++ test/nrepl-dict-tests.el | 2 ++ 32 files changed, 63 insertions(+), 1 deletion(-) diff --git a/test/cider-apropos-tests.el b/test/cider-apropos-tests.el index 227c4a31f9..e832b4ad43 100644 --- a/test/cider-apropos-tests.el +++ b/test/cider-apropos-tests.el @@ -30,6 +30,8 @@ (require 'buttercup) (require 'cider-apropos) +;; Please, for each `describe', ensure there's an `it' block, so that its execution is visible in CI. + (describe "cider-apropos" (it "raises user-error when cider is not connected." (spy-on 'cider-connected-p :and-return-value nil) diff --git a/test/cider-browse-ns-tests.el b/test/cider-browse-ns-tests.el index f621c74c65..080c9c1f51 100644 --- a/test/cider-browse-ns-tests.el +++ b/test/cider-browse-ns-tests.el @@ -30,6 +30,8 @@ (require 'buttercup) (require 'cider-browse-ns) +;; Please, for each `describe', ensure there's an `it' block, so that its execution is visible in CI. + (describe "cider-browse-ns--text-face" (it "identifies a function" (expect (cider-browse-ns--text-face '(dict "arglists" "fn arg list")) diff --git a/test/cider-browse-spec-tests.el b/test/cider-browse-spec-tests.el index 8907529466..e550f97ad0 100644 --- a/test/cider-browse-spec-tests.el +++ b/test/cider-browse-spec-tests.el @@ -29,6 +29,8 @@ (require 'buttercup) (require 'cider-browse-spec) +;; Please, for each `describe', ensure there's an `it' block, so that its execution is visible in CI. + (defvar cider-browse-spec-tests--schema-vector-response '("clojure.alpha.spec/schema" (":example.customer/id" ":example.customer/name")) diff --git a/test/cider-classpath-tests.el b/test/cider-classpath-tests.el index 09fdda0925..5b41b267c4 100644 --- a/test/cider-classpath-tests.el +++ b/test/cider-classpath-tests.el @@ -30,6 +30,8 @@ (require 'buttercup) (require 'cider-classpath) +;; Please, for each `describe', ensure there's an `it' block, so that its execution is visible in CI. + (describe "cider-classpath" (it "raises user-error when cider is not connected." (spy-on 'cider-connected-p :and-return-value nil) diff --git a/test/cider-client-tests.el b/test/cider-client-tests.el index c24141cb59..5050673976 100644 --- a/test/cider-client-tests.el +++ b/test/cider-client-tests.el @@ -33,6 +33,8 @@ (require 'cider-connection) (require 'cider-connection-test-utils "test/utils/cider-connection-test-utils") +;; Please, for each `describe', ensure there's an `it' block, so that its execution is visible in CI. + ;;; cider-client tests (describe "cider-var-info" diff --git a/test/cider-clojuredocs-tests.el b/test/cider-clojuredocs-tests.el index 7ee4c664fe..867e475b51 100644 --- a/test/cider-clojuredocs-tests.el +++ b/test/cider-clojuredocs-tests.el @@ -30,6 +30,8 @@ (require 'buttercup) (require 'cider-clojuredocs) +;; Please, for each `describe', ensure there's an `it' block, so that its execution is visible in CI. + ;;; clojuredocs tests (describe "cider-clojuredocs-replace-special" diff --git a/test/cider-common-tests.el b/test/cider-common-tests.el index afb2b56259..b918811b72 100644 --- a/test/cider-common-tests.el +++ b/test/cider-common-tests.el @@ -30,6 +30,8 @@ (require 'buttercup) (require 'cider-common) +;; Please, for each `describe', ensure there's an `it' block, so that its execution is visible in CI. + ;;; cider-common tests (describe "cider-abbreviate-ns" (it "handles nil input" diff --git a/test/cider-connection-tests.el b/test/cider-connection-tests.el index a397d5a8c1..803035b386 100644 --- a/test/cider-connection-tests.el +++ b/test/cider-connection-tests.el @@ -33,6 +33,8 @@ (require 'cider-connection) (require 'cider-connection-test-utils "test/utils/cider-connection-test-utils") +;; Please, for each `describe', ensure there's an `it' block, so that its execution is visible in CI. + (describe "cider-ensure-connected" :var (sesman-sessions-hashmap sesman-links-alist ses-name ses-name2) diff --git a/test/cider-debug-tests.el b/test/cider-debug-tests.el index 9c89d7c67b..34b69ef1d3 100644 --- a/test/cider-debug-tests.el +++ b/test/cider-debug-tests.el @@ -31,6 +31,8 @@ (require 'clojure-mode) (require 'cider-debug) +;; Please, for each `describe', ensure there's an `it' block, so that its execution is visible in CI. + (describe "cider--debug-prompt" (it "changes the font face to `cider-debug-prompt-face' for the first char" (let ((cider-debug-prompt-commands '((?a "abc" "abc") (?x "xyz" "xyz")))) diff --git a/test/cider-doc-tests.el b/test/cider-doc-tests.el index f4b680064f..38dcc89fdf 100644 --- a/test/cider-doc-tests.el +++ b/test/cider-doc-tests.el @@ -28,6 +28,8 @@ (require 'buttercup) (require 'cider-doc) +;; Please, for each `describe', ensure there's an `it' block, so that its execution is visible in CI. + (describe "cider--abbreviate-file-protocol" (it "Removes the file or jar part" (expect (cider--abbreviate-file-protocol "file:foo.clj") diff --git a/test/cider-eldoc-tests.el b/test/cider-eldoc-tests.el index 1033ebcef8..d60ebb6018 100644 --- a/test/cider-eldoc-tests.el +++ b/test/cider-eldoc-tests.el @@ -30,6 +30,8 @@ (require 'buttercup) (require 'cider-eldoc) +;; Please, for each `describe', ensure there's an `it' block, so that its execution is visible in CI. + (describe "cider--find-rest-args-position" (it "returns the position of & in the arglist vector" (expect (cider--find-rest-args-position ["fmt" "&" "arg"]) diff --git a/test/cider-error-parsing-tests.el b/test/cider-error-parsing-tests.el index addf9e275e..a73e080059 100644 --- a/test/cider-error-parsing-tests.el +++ b/test/cider-error-parsing-tests.el @@ -30,6 +30,8 @@ (require 'cider-eval) (require 'buttercup) +;; Please, for each `describe', ensure there's an `it' block, so that its execution is visible in CI. + (describe "cider-extract-error-info" :var (file-name line-num col-num face) (before-all diff --git a/test/cider-eval-tests.el b/test/cider-eval-tests.el index 23cff5ee75..d9f46e3ea4 100644 --- a/test/cider-eval-tests.el +++ b/test/cider-eval-tests.el @@ -28,6 +28,8 @@ (require 'buttercup) (require 'cider-eval) +;; Please, for each `describe', ensure there's an `it' block, so that its execution is visible in CI. + (describe "cider-provide-file" (it "returns an empty string when the file is not found" (expect (cider-provide-file "abc.clj") :to-equal "")) diff --git a/test/cider-find-tests.el b/test/cider-find-tests.el index fc139e613b..1c5c742acd 100644 --- a/test/cider-find-tests.el +++ b/test/cider-find-tests.el @@ -28,6 +28,8 @@ (require 'buttercup) (require 'cider-find) +;; Please, for each `describe', ensure there's an `it' block, so that its execution is visible in CI. + (describe "cider-find-ns" (it "raises a user error if cider is not connected" (spy-on 'cider-connected-p :and-return-value nil) diff --git a/test/cider-font-lock-tests.el b/test/cider-font-lock-tests.el index e1bcd29b5e..66620aef7f 100644 --- a/test/cider-font-lock-tests.el +++ b/test/cider-font-lock-tests.el @@ -26,6 +26,7 @@ (require 'buttercup) (require 'cider-mode) +;; Please, for each `describe', ensure there's an `it' block, so that its execution is visible in CI. ;; Utilities diff --git a/test/cider-interaction-tests.el b/test/cider-interaction-tests.el index 723479dbed..33c873dc30 100644 --- a/test/cider-interaction-tests.el +++ b/test/cider-interaction-tests.el @@ -31,6 +31,8 @@ (require 'cider-eval) (require 'cider-connection-test-utils "test/utils/cider-connection-test-utils") +;; Please, for each `describe', ensure there's an `it' block, so that its execution is visible in CI. + (describe "cider--var-namespace" (it "returns the namespace of a var" (expect (cider--var-namespace "#'a/var-two") :to-equal "a") diff --git a/test/cider-jar-tests.el b/test/cider-jar-tests.el index e639ebd2dd..d4ecdfef71 100644 --- a/test/cider-jar-tests.el +++ b/test/cider-jar-tests.el @@ -29,6 +29,8 @@ (require 'cider-jar) (require 'map) +;; Please, for each `describe', ensure there's an `it' block, so that its execution is visible in CI. + (describe "cider-jar--cider-nrepl-clojars-url" (it "Builds a Clojars url" (expect (cider-jar-clojars-url "cider" "cider-nrepl" "0.1.2") diff --git a/test/cider-locals-tests.el b/test/cider-locals-tests.el index 423d781a74..6b0e2629ae 100644 --- a/test/cider-locals-tests.el +++ b/test/cider-locals-tests.el @@ -20,6 +20,8 @@ (require 'buttercup) (require 'cider-mode) +;; Please, for each `describe', ensure there's an `it' block, so that its execution is visible in CI. + (defmacro cider--test-with-content (content expected &rest body) (declare (indent 2) (debug t)) diff --git a/test/cider-log-tests.el b/test/cider-log-tests.el index 662f9fc061..9a8aa30481 100644 --- a/test/cider-log-tests.el +++ b/test/cider-log-tests.el @@ -28,6 +28,8 @@ (require 'buttercup) (require 'cider-log) +;; Please, for each `describe', ensure there's an `it' block, so that its execution is visible in CI. + (describe "cider-log" (let ((framework (nrepl-dict "id" "jul" "name" "Java Util Logging")) (appender (nrepl-dict "id" "cider-log"))) diff --git a/test/cider-ns-tests.el b/test/cider-ns-tests.el index 798e0afe25..e7649ea8da 100644 --- a/test/cider-ns-tests.el +++ b/test/cider-ns-tests.el @@ -28,6 +28,8 @@ (require 'buttercup) (require 'cider-ns) +;; Please, for each `describe', ensure there's an `it' block, so that its execution is visible in CI. + (describe "cider-ns-refresh" (it "raises a user error if cider is not connected" (spy-on 'cider-connected-p :and-return-value nil) diff --git a/test/cider-overlay-tests.el b/test/cider-overlay-tests.el index 57fdca85ac..2b7450f6a3 100644 --- a/test/cider-overlay-tests.el +++ b/test/cider-overlay-tests.el @@ -23,6 +23,8 @@ (require 'cider-overlays) +;; Please, for each `describe', ensure there's an `it' block, so that its execution is visible in CI. + (defmacro cider--overlay-temp-buffer (&rest body) "Run `body' in a temp buffer with some text. Also set `this-command' to true by default, as some parts of `cider--make-result-overlay rely on it diff --git a/test/cider-repl-tests.el b/test/cider-repl-tests.el index 8a1ff605ce..4596d3e429 100644 --- a/test/cider-repl-tests.el +++ b/test/cider-repl-tests.el @@ -30,6 +30,8 @@ (require 'buttercup) (require 'cider-repl) +;; Please, for each `describe', ensure there's an `it' block, so that its execution is visible in CI. + (describe "cider-repl--insert-param-values" (it "doesn't output anything when the params aren't present" (let ((output "") diff --git a/test/cider-selector-tests.el b/test/cider-selector-tests.el index 88e87ff318..6bd11539ba 100644 --- a/test/cider-selector-tests.el +++ b/test/cider-selector-tests.el @@ -31,6 +31,8 @@ (require 'cider-selector) (require 'cider-connection-test-utils "test/utils/cider-connection-test-utils") +;; Please, for each `describe', ensure there's an `it' block, so that its execution is visible in CI. + ;; selector (defun cider-invoke-selector-method-by-key (ch) (let ((method (cl-find ch cider-selector-methods :key #'car))) diff --git a/test/cider-stacktrace-tests.el b/test/cider-stacktrace-tests.el index f528d7dbca..f68eada4d7 100644 --- a/test/cider-stacktrace-tests.el +++ b/test/cider-stacktrace-tests.el @@ -30,6 +30,8 @@ (require 'buttercup) (require 'cider-stacktrace) +;; Please, for each `describe', ensure there's an `it' block, so that its execution is visible in CI. + ;; cider-stacktrace test data (defvar cider-stacktrace-tests-boom-aviso diff --git a/test/cider-test-tests.el b/test/cider-test-tests.el index 35b2c3fd5a..d56409175a 100644 --- a/test/cider-test-tests.el +++ b/test/cider-test-tests.el @@ -28,6 +28,8 @@ (require 'buttercup) (require 'cider-test) +;; Please, for each `describe', ensure there's an `it' block, so that its execution is visible in CI. + (describe "cider-test--string-contains-newline" (it "Returns `t' only for escaped newlines" (expect (cider-test--string-contains-newline "n") diff --git a/test/cider-tests--no-auto.el b/test/cider-tests--no-auto.el index e05dc75c64..b76c7e8aa8 100644 --- a/test/cider-tests--no-auto.el +++ b/test/cider-tests--no-auto.el @@ -34,6 +34,8 @@ (require 'cider) (require 'subr-x) +;; Please, for each `describe', ensure there's an `it' block, so that its execution is visible in CI. + ;;; Docs ;; Presenting docs erroneously would cause an ugly scene. diff --git a/test/cider-tests.el b/test/cider-tests.el index 16f7107b52..b804211598 100644 --- a/test/cider-tests.el +++ b/test/cider-tests.el @@ -30,6 +30,8 @@ (require 'buttercup) (require 'cider) +;; Please, for each `describe', ensure there's an `it' block, so that its execution is visible in CI. + (describe "customize-menu" (it "opens without error" (let ((inhibit-message t)) (customize-group 'cider)))) diff --git a/test/cider-util-tests.el b/test/cider-util-tests.el index aca6f301df..d877a30162 100644 --- a/test/cider-util-tests.el +++ b/test/cider-util-tests.el @@ -31,6 +31,8 @@ (require 'cider-util) (require 'package) +;; Please, for each `describe', ensure there's an `it' block, so that its execution is visible in CI. + (defmacro with-clojure-buffer (contents &rest body) "Execute BODY in a clojure-mode buffer with CONTENTS diff --git a/test/integration/integration-tests.el b/test/integration/integration-tests.el index 7f7a970ea2..caa1c23501 100644 --- a/test/integration/integration-tests.el +++ b/test/integration/integration-tests.el @@ -31,6 +31,8 @@ (require 'nrepl-tests-utils "test/utils/nrepl-tests-utils") (require 'integration-test-utils) +;; Please, for each `describe', ensure there's an `it' block, so that its execution is visible in CI. + (defun jack-in-clojure-cli-test (cli-command) "Run clojure cli jack in test using given CLI-COMMAND. @@ -549,4 +551,3 @@ If CLI-COMMAND is nil, then use the default." (expect (member (process-status nrepl-proc) '(exit signal))))))))))) ;;; integration-tests.el ends here - diff --git a/test/nrepl-bencode-tests.el b/test/nrepl-bencode-tests.el index c6484a142f..1960cd362c 100644 --- a/test/nrepl-bencode-tests.el +++ b/test/nrepl-bencode-tests.el @@ -31,6 +31,8 @@ (require 'cl-lib) (require 'nrepl-client) +;; Please, for each `describe', ensure there's an `it' block, so that its execution is visible in CI. + ;; Workaround for silex/master-dev issue with buggy old snapshot. To be removed ;; once new snapshot image is build. (when (= emacs-major-version 29) diff --git a/test/nrepl-client-tests.el b/test/nrepl-client-tests.el index 7f6b7c6bf1..e02692fe75 100644 --- a/test/nrepl-client-tests.el +++ b/test/nrepl-client-tests.el @@ -31,6 +31,8 @@ (require 'nrepl-client) (require 'nrepl-tests-utils "test/utils/nrepl-tests-utils") +;; Please, for each `describe', ensure there's an `it' block, so that its execution is visible in CI. + (describe "nrepl-server-buffer-name" :var (nrepl-hide-special-buffers params default-directory-backup cider-session-name-template) diff --git a/test/nrepl-dict-tests.el b/test/nrepl-dict-tests.el index 6acf0f5df4..e7b1bb1405 100644 --- a/test/nrepl-dict-tests.el +++ b/test/nrepl-dict-tests.el @@ -30,6 +30,8 @@ (require 'buttercup) (require 'nrepl-dict) +;; Please, for each `describe', ensure there's an `it' block, so that its execution is visible in CI. + (describe "nrepl-dict-merge" :var (input) (before-each