branch: externals/dired-preview commit 0fa9aab1dfbe104b99b1a96c9cdf894de47b6e00 Author: Protesilaos Stavrou <i...@protesilaos.com> Commit: Protesilaos Stavrou <i...@protesilaos.com>
Add FIXME for how/why window parameters are unset --- dired-preview.el | 3 +++ 1 file changed, 3 insertions(+) diff --git a/dired-preview.el b/dired-preview.el index 303fbcc84b..faf131f3e8 100644 --- a/dired-preview.el +++ b/dired-preview.el @@ -117,6 +117,9 @@ details." (defun dired-preview--run-mode-hooks () "Run mode hooks in current buffer, if `delayed-mode-hooks' is non-nil." (when (and delay-mode-hooks (current-buffer)) + ;; FIXME 2023-07-05: When we remove the window parameters, we + ;; disconnect the window from the preview. Then what is the point + ;; of trying to close previews outside of Dired? Which previews? (set-window-parameter (selected-window) 'dired-preview-window nil) (set-window-parameter (selected-window) 'dedicated nil) (apply #'run-hooks (delete-dups delayed-mode-hooks))