Jon Shapcott <[EMAIL PROTECTED]> wrote Fri, May 06, 2005: > On Fri, May 06, 2005 at 08:47:47PM +0200, Jonas Fonseca wrote: > > Miciah Dashiel Butler Masters <[EMAIL PROTECTED]> wrote Fri, May 06, 2005: > > > - info_box(errterm, MSGBOX_NO_TEXT_INTL, > > > + info_box(errterm, MSGBOX_NO_TEXT_INTL, MSGBOX_FREE_TEXT, > > > > MSGBOX_NO_TEXT_INTL | MSGBOX_FREE_TEXT, > > > > The two MSGBOX flags should be ORed together. > > I figured that out when the compiler complained at me. Long time since I've > hacked C, but those idioms still stick in the mind. > > Copying the string and telling the dialog to free it worked for me.
Great! :) Miciah, will you commit the fix? Looks like 0.10 is also affected. > Although I'm still a little puzzled as to why it suddenly started. It > was doing the same thing for both alert_lua_error and > alert_lua_error2, even with the extra copying going on in > alert_lua_error2. The Lua C code has not gotten so much attention lately. But I agree this is a bit stupid. > Thanks a lot for the help. I should return the favour, and maybe hack some > on the unstable version. Both core.c and hooks.c get quite a lot shorter > when you turn the cut'n'paste into functions, a drop some of the arcane > passing of the global lua_State in and out of dialog events. Don't mind if you do. ;) > Now to get those function references into the lua 5 api ... Huh? -- Jonas Fonseca _______________________________________________ elinks-users mailing list [email protected] http://linuxfromscratch.org/mailman/listinfo/elinks-users
