Hi Aaron, On Sun, 2026-03-15 at 10:33 -0400, Aaron Merey wrote: > On Sat, Mar 14, 2026 at 10:59 AM Frank Ch. Eigler <[email protected]> wrote: > > I'm not crazy wild about exporting the default progressfn from the > > solib, but can see how it makes debuginfod-find.c simpler than having > > to replicate that function, so LGTMish. :-) > > Another option is to create a libdebuginfodP.h akin to libelfP.h and > libdwP.h. This internal header can expose the default progressfn to > debuginfod-find without making it part of the public API. However I > think it'd be useful if other debuginfod clients could call the > default progressfn directly.
I agree making this public/exported is nicer for other clients. Only comment I have on the patch is that if we do add this then we should also add a man page, which could simply be a file doc/debuginfod_default_progressfn containing: .so man3/debuginfod_find_debuginfo.3 Cheers, Mark
