On Fri, Apr 25, 2025, at 1:57 AM, Aaron Merey wrote:
> Also if you haven't done so already, please run any manual tests under
> valgrind memcheck (and helgrind if you are able to test this with
> multithreading).
Ran eu-stacktrace through valgrind; the content of the cache is marked as
'leaked' since eu-stacktrace doesn't bother to call elf_end
(the caller of the find_elf callback holds a refcount in addition to the cache
itself,
to allow a user that *does* like to call elf_end() to continue doing so without
invalidating the cached copy).
This could be mitigated by having eu-stacktrace release the Elf *
when they are placed in the cache, but I'll leave that for later work.
--
All the best,
Serhei
http://serhei.io
- [PATCH v5 10/12] eu-stacktrace [10/12]: use dwflst_tracker_... Serhei Makarov
- [PATCH v5 09/12] libdwfl_stacktrace [9/12]: add dwflst_trac... Serhei Makarov
- [PATCH v5 07/12] eu-stacktrace [7/12]: use Dwflst_Process_T... Serhei Makarov
- [PATCH v5 04/12] libdwfl_stacktrace [4/12]: intro library, ... Serhei Makarov
- [PATCH v5 06/12] libdwfl_stacktrace [6/12]: Elf* caching vi... Serhei Makarov
- Re: [PATCH v5 06/12] libdwfl_stacktrace [6/12]: Elf* c... Aaron Merey
- Re: [PATCH v5 06/12] libdwfl_stacktrace [6/12]: El... Serhei Makarov
- [PATCH v5 08/12] libdwfl_stacktrace [8/12]: Dwfl* caching v... Serhei Makarov
- [PATCH v5 12/12] eu-stacktrace [12/12]: use dwflst_perf_sam... Serhei Makarov
- [PATCH v5 11/12] libdwfl_stacktrace [11/12]: add dwflst_per... Serhei Makarov
- Re: [PATCH v5 01/12] libebl [1/12]: api for perf register h... Aaron Merey
