Hi Mark,
On Fri, Apr 04, 2025 at 01:55:48PM +0200, Mark Wielaard wrote:
> Hi Dmitry,
>
> On Thu, 2025-04-03 at 19:28 +0300, Dmitry V. Levin wrote:
> > I've accidentally noticed that this hunk was not correct back in 2017
> > because "#if HAVE_CONFIG_H" is not the same as "#ifdef HAVE_CONFIG_H".
> > This was not problematic for elfutils itself because HAVE_CONFIG_H is
> > always defined.
> >
> > Note, however, that as a side effect of commit 76c84c137a82 ("handle libc
> > implementations which do not provide `error.h`") "system.h" now includes
> > <config.h> unconditionally, essentially reintroducing the original issue
> > of including config.h twice for all files that include both <config.h>
> > and "system.h".
>
> So to be (pedantically) correct should we include the attached?
Yes, this should be fine, along with
--- a/lib/crc32.c
+++ b/lib/crc32.c
@@ -28 +28 @@
-#if HAVE_CONFIG_H
+#ifdef HAVE_CONFIG_H
--
ldv
