Hi Serhei, On Tue, Oct 15, 2024 at 11:28 AM Serhei Makarov <ser...@serhei.io> wrote: > > Due to the x86-specific code in the initial version the configury has > significant restrictions. If --enable-stacktrace is not explicitly > provided, then eu-stacktrace will be disabled by default when > x86 architecture or sysprof headers are absent. > > The way we test for x86 is a bit unusual. What we actually care about > is that the register file provided by perf_events on the system is an > x86 register file; this is done by checking that <asm/perf_regs.h> is > Linux kernel arch/x86/include/uapi/asm/perf_regs.h. > > Once eu-stacktrace is properly portable across architectures, > these grody checks can be simplified. > > * configure.ac: Add configure checks and conditionals for stacktrace tool. > * src/Makefile.am: Add stacktrace tool conditional on ENABLE_STACKTRACE. > > Signed-off-by: Serhei Makarov <ser...@serhei.io> > --- > configure.ac | 66 ++++++++++++++++++++++++++++++++++++++++++++++++- > src/Makefile.am | 9 ++++++- > 2 files changed, 73 insertions(+), 2 deletions(-)
Using less wide indentation throughout would help make the configure.ac changes more readable. Otherwise this patch LGTM. Aaron
