On Tue, Jul 16, 2024 at 04:16:01PM -0400, Frank Ch. Eigler wrote:
> Hi -
>
> > This is v2 of my patch series optimizing debuginfod for kernel
> > debuginfo. v1 is here [7].
>
> This generally looks great to me. I'll send it through the testsuite
> trybots here.
Great, thank you!
> But there isn't an xz-y test case yet. Is there a
> smallish seekable-xz rpm file that you have or could make that we
> could jam into the elfutils testsuite?
Good point, I'll add one.
> (A prometheus metric counting
> seeked-xz attempts/successes would be cool to assist testing and to
> monitor it on deployed servers.)
I do have:
inc_metric("error_count","lzma",to_string(rc));
in lzma_exception and:
inc_metric ("http_responses_total","result",metric);
in create_buildid_r_response, which gets called with
metric = "seekable archive". But I'll add another metric for attempts,
and name the existing one "seekable xz archive" to be more explicit.
Thanks,
Omar
