Hi Omar, On Wed, Sep 27, 2023 at 11:20:49AM -0700, Omar Sandoval wrote: > This patch series adds support for DWARF package files to libdw and the > elfutils tools. It supports the GNU DebugFission format for DWARF 4 [1] > and the format standardized in DWARF 5 (section 7.3.5 "DWARF Package > Files"). It supports both automatically opening the .dwp file for a > skeleton unit and examining the .dwp file alone, just like for .dwo > files.
I had hoped to review and apply all this for the 0.190 release tomorrow, but wasn't fast enough. In general it looks very good and most has been applied as is. Except for the last patch I don't have real concerns, just a few questions (see the specific reviews). > Patch 1 is a trivial cleanup I found while developing this. Patches 2-6 > are fixes for unrelated bugs in split DWARF and/or DWARF 5 that I > encountered while adding test cases for this series. These have all been applied some time ago. > The actual dwp support is in patches 7-10 and 13, including test cases. 7 and 9 have been applied already. 8 has some comments/nitpicks, I can probably easily be convinced to accept it. 10 looks good, but depends on 8, some questions, specificly about handling split type units. 13 looks good, but depends on 8 and 10. > Patches 11 and 12 enable testing macro information in dwp files. Both applied. > Patch 14 adds support and tests for an LLVM extension to the dwp > format. I have to think a bit more on this. Cheers, Mark
