Hi Omar, On Wed, 2023-09-27 at 11:20 -0700, Omar Sandoval wrote: > From: Omar Sandoval <osan...@fb.com> > > dwarf_getmacros handles the additional macro string forms added by DWARF > 5, but dwarf_macro_param2 doesn't. Update it with the list of all > string forms allowed in .debug_macro. In particular, GCC and Clang > generate DW_MACRO_define_strx and DW_MACRO_undef_strx, which > dwarf_macro_param2 couldn't handle.
So as far as I can see this is always only used for DWARF5 forms and never uses the DW_FORM_GNU_strp_alt or DW_FORM_GNU_str_index because the GNU DebugFission extension for DWARF4 kept the old macinfo format, just moved it to the dwo. Thanks for catching this. Applied. Cheers, Mark
