I split it into small patches for easier to review Changes v1->v2: The reviews are applied
Yonggang Luo (16): ignore build directory move platform depended include into system.h of libebl Use configure to detect HAVE_DECL_MMAP and use it for system doesn't provide sys/mman.h Fixes usage of basename about prototype differences libcpu: Remove the need of NMNES by using enum libcpu: Use __asm instead asm that can be recognized by both clang-cl and gcc libdw: Fixes compile of dwarf_whatattr.c and dwarf_whatform.c lib: Implement error properly even when not HAVE_ERR_H libelf: uid_t, gid_t and mode_t are not comes with msvcrt, so using long/unsigned long instead on win32 libasm: stdio_ext.h are not present on win32 libebl/libdwelf: define ssize_t and pid_t for MSVC within installed header libdwelf.h and libebl.h libasm/debuginfod: fchmod doesn't present on win32 lib: isatty is not available on windows Add function sys_get_page_size to replace platform dependent sysconf (_SC_PAGESIZE) libelf: F_GETFD may not predefined with msvc/mingw, guard the usage of it lib: Use HAVE_LIBINTL_H to guard #include <libintl.h> .gitignore | 1 + ChangeLog | 4 ++ configure.ac | 3 + debuginfod/debuginfod-client.c | 4 +- lib/Makefile.am | 2 +- lib/color.c | 5 ++ lib/crc32_file.c | 6 +- lib/error.c | 16 ++++- lib/eu-config.h | 7 ++ libdw/dwarf_whatform.c => lib/system.c | 90 ++++++++++++++------------ lib/system.h | 9 ++- libasm/asm_begin.c | 7 +- libasm/asm_end.c | 2 + libcpu/Makefile.am | 2 +- libcpu/i386_disasm.c | 16 +---- libcpu/i386_mne.h | 36 +++++++++++ libcpu/i386_parse.y | 9 +-- libdw/dwarf_begin_elf.c | 2 +- libdw/dwarf_getsrc_file.c | 2 +- libdw/dwarf_whatattr.c | 9 ++- libdw/dwarf_whatform.c | 9 ++- libdwelf/dwelf_strtab.c | 2 +- libdwelf/libdwelf.h | 5 ++ libdwfl/dwfl_module_getsrc_file.c | 2 +- libdwfl/dwfl_segment_report_module.c | 2 +- libdwfl/find-debuginfo.c | 6 +- libdwfl/link_map.c | 2 +- libdwfl/linux-kernel-modules.c | 2 +- libdwfl/linux-proc-maps.c | 2 +- libebl/eblauxvinfo.c | 2 - libebl/eblcorenote.c | 2 - libebl/ebldynamictagname.c | 1 - libebl/eblobjnote.c | 8 +-- libebl/eblobjnotetypename.c | 2 - libebl/eblopenbackend.c | 1 - libebl/libebl.h | 5 ++ libebl/libeblP.h | 1 + libelf/elf32_updatefile.c | 5 +- libelf/elf_begin.c | 12 +++- libelf/elf_end.c | 2 + libelf/elf_update.c | 5 +- libelf/libelf.h | 6 ++ src/addr2line.c | 4 +- src/ar.c | 2 +- src/nm.c | 4 +- src/ranlib.c | 2 +- src/stack.c | 2 +- src/strings.c | 2 +- src/strip.c | 2 +- 49 files changed, 215 insertions(+), 119 deletions(-) copy libdw/dwarf_whatform.c => lib/system.c (66%) create mode 100644 libcpu/i386_mne.h -- 2.36.1.windows.1