Hi Frank, On Sun, 2021-12-05 at 18:30 +0100, Mark Wielaard wrote: > On Tue, Oct 05, 2021 at 06:55:34PM +0200, Mark Wielaard wrote: > > On Thu, 2021-09-30 at 10:50 -0400, Frank Ch. Eigler via Elfutils-devel > > wrote: > > > commit 85602ff68179053f19a2005df4fc653a69757584 (HEAD -> master) > > > Author: Frank Ch. Eigler <f...@redhat.com> > > > Date: Thu Sep 30 10:48:00 2021 -0400 > > > > > > debuginfod testsuite: Use ! CMD syntax. > > > > > > Previously, we had a mishmash of iffy && || constructs to > > > reverse the rc of a subprocess that we expected to fail. > > > Now use > > > ! CMD > > > or > > > ! (CMD | CMD) > > > more systematically where possible. > > > > > > Signed-off-by: Frank Ch. Eigler <f...@redhat.com> > > > > Thanks, the && || conditionals do make my head hurt (I am not as > > logical as I like). This looks much simpler. > > > > I wish we can use this. But we use -e to make any failing command > > (pipeline) fail the script/test. And man bash says (under -e Exit > > immediately): > > > > The shell does not exit if the command that fails is part of the > > command list immediately following a while or until keyword, part > > of the test following the if or elif reserved words, part of any > > command executed in a && or || list except the command following > > the final && or ||, any command in a pipeline but the last, or if > > the command's return value is being inverted with !. > > > > So I am afraid any '! should_fail_but_does_not' will not actually exit > > and so doesn't FAIL the test. Could you double check that? > > Have you looked into this? Is it something we can workaround? Or > should we drop this idea for now?
I think we should drop this patch for now. Or are you still working on it? Thanks, Mark
