Hi Alice, (adding elfutils-devel back to CC so other know what we discussed)
On Wed, 2021-08-04 at 17:36 -0400, Alice Zhang wrote: > Hi Mark, I made debuginfod-client-config.7 a relatively complete man page > and include only the part we need into other files by using > $.if \n(zZ=1 .ig zZ > ... > $.zZ > ... > I also changed .*so ./debuginfod-client-config.7* to *.so > man7/debuginfod-client-config.7*, since I found some similar usage in > debuginfod_get_url.3, like *$.so man3/debuginfod_find_debuginfo.3*. > > The Attachment is the new patch, let me know if any other modifications are > needed. Very nice, you understood the include guards that were puzzling me. This looks very nice. I think the only thing that is needed is actually installing the new manpage with something like: notrans_dist_man7_MANS = debuginfod-client-config.7 in doc/Makefile.am (probably under the if LIBDEBUGINFOD. And then double check that man debuginfod-client-config and man debuginfod_get_url etc. work when everything is installed. e.g. If you configure --prefix=/tmp/elfutils-install && make && make install and then set MANPATH export MANPATH=/tmp/elfutils-install that man debuginfod-client-config and man debuginfod_find_debuginfo product the correct results (show the includes). Thanks, Mark
