On Sat, Jan 12, 2019 at 2:29 PM Mark Wielaard <m...@klomp.org> wrote: > I don't really like adding code that cannot be tested. But it does look > the 32-bit port isn't far off, just waiting for the next linux/glibc > release to settle the time_t ABI. And the code does look correct. > Except for...
We don't expect 32-bit desktop linux distros, but there are folks that want 32-bit embedded linux. A few companies have gotten it working, but only Andes is trying to upstream patches so far, and as you mentioned that is waiting for the time_t ABI. Meanwhile, it should be possible to build a busy-box style 32-bit linux system, using an old obsolete pre-upstream glibc port, but that isn't useful for real development work. > > static const Ebl_Register_Location prstatus_regs[] = > > { > > - { .offset = 8, .regno = 1, .count = 31, .bits = 64 } /* x1..x31 */ > > + { .offset = BITS/8, .regno = 1, .count = 31, .bits = 64 } /* x1..x31 */ > > }; > > Should that be .bits = BITS ? Yes, sorry, I was looking at the offset field and completely missed the bits member at the end. Do you want me to submit an updated patch? Jim