Hello Christopher, Thanks for taking the time to test the iTCO v4 patch.
> -----Original Message----- > From: Christopher Obbard <[email protected]> > Sent: Monday, June 10, 2024 5:55 PM > To: Mathieu Alexandre-Tetreault <[email protected]>; efibootguard- > [email protected] > Subject: Re: [PATCH] Add support for iTCOv4 (Sunrise Point-LP) > > [You don't often get email from [email protected]. Learn why this is > important at https://aka.ms/LearnAboutSenderIdentification ] > > Hi, > > I've tried to enable iTCO v4 on a Lenovo Thinkcenter with an i5-6500 using > this > patch. > > > I've modified the patch to update the no_reboot_mask which Jan has already > pointed out (as well as fixing the formatting issues): > > @@ -101,9 +111,17 @@ static const iTCO_regs iTCO_version_regs[] = { > .pm_base_reg = 0x40, > .pm_base_addr_mask = 0x0000ff80, > }, > [ITCO_V4] = > { > - /* Not implemented yet */ > + .pmc_base_reg = 0x10, > + .pmc_reg = 0x1008, > + .pmc_no_reboot_mask = (1 << 1), > + .pmc_base_addr_mask = 0xfffffe00, > + .pm_base_reg = 0x400, > + .pm_base_addr_mask = 0x0000ff80, > }, > > > .. and I've added the PCI ID for this SoC to the device mapping table ... > > @@ -240,6 +258,27 @@ static const iTCO_info iTCO_chipset_info[] = { > .pci_id = 0x5796, > .itco_version = ITCO_V6, > }, > + [ITCO_INTEL_SUNRISE_H] = > + { > + .name = L"Sunrise Point-H", > + .pci_id = 0xa123, > + .itco_version = ITCO_V4, > + }, > > > > but the watchdog doesn't probe on that device and efibootguard simply > errors out with: > > Detected Intel TCO Sunrise Point-H watchdog > ERROR: reading PM_BASE: Unsupported > > > so this mail is a NACK for the original patch, enabling iTCO v4. Did you > manage > to test it on real hardware? It was tested on real hardware and it was working. I'll double-check this patch against the one we use for v0.8. I am starting to think that there was some manipulation errors. Thanks for reporting the issue. I asked to get access to the iTCO v4 device in order to test this further. > > > Thanks, > > Chris Regards, Mathieu -- You received this message because you are subscribed to the Google Groups "EFI Boot Guard" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/efibootguard-dev/YT2P288MB0074FFB21E40F82EC30D4B84B7C72%40YT2P288MB0074.CANP288.PROD.OUTLOOK.COM.
