Branch: refs/heads/master
Home: https://github.com/tianocore/edk2
Commit: a757b8cae316724ef2e5f696dd610b68b19503d3
https://github.com/tianocore/edk2/commit/a757b8cae316724ef2e5f696dd610b68b19503d3
Author: Varshit Pandya <[email protected]>
Date: 2026-09-10 (Thu, 10 Sep 2026)
Changed paths:
M DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c
Log Message:
-----------
DynamicTablesPkg: Fix AmlLib Notify operand ownership
Ensure AmlCodeGenNotifyNode() consistently owns its operand nodes after
successful input validation.
Track operands as they are attached to the Notify object so error
handling deletes unattached operands directly and attached operands
through their parent. Clear the caller references after ownership is
transferred to prevent double deletion on failure.
Signed-off-by: Varshit Pandya <[email protected]>
Commit: 573ffa48dfb8b6709fbcccecd29e820800ce26a7
https://github.com/tianocore/edk2/commit/573ffa48dfb8b6709fbcccecd29e820800ce26a7
Author: Varshit Pandya <[email protected]>
Date: 2026-09-10 (Thu, 10 Sep 2026)
Changed paths:
M DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h
Log Message:
-----------
DynamicTablesPkg: Document AmlLib code generator APIs
Add AmlCodeGenMethod() and other missing public functions to the
CodeGen API documentation group.
Signed-off-by: Varshit Pandya <[email protected]>
Commit: 7483abf198a30204763b870285e0fa5ea2e49a85
https://github.com/tianocore/edk2/commit/7483abf198a30204763b870285e0fa5ea2e49a85
Author: Varshit Pandya <[email protected]>
Date: 2026-09-10 (Thu, 10 Sep 2026)
Changed paths:
M DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h
M DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c
Log Message:
-----------
DynamicTablesPkg: Expose AmlLib Notify generator
Make AmlCodeGenNotify() public and declare it in AmlLib.h. Add the new
API to the CodeGen documentation group.
Callers currently cannot append an individual Notify operation while
incrementally constructing a method body.
For example, this enables generators to construct _EVT methods
containing conditional register writes and device notifications.
Signed-off-by: Varshit Pandya <[email protected]>
Commit: b87f01813b20b7bc2f61fe39bb71dad76f0c5b16
https://github.com/tianocore/edk2/commit/b87f01813b20b7bc2f61fe39bb71dad76f0c5b16
Author: Varshit Pandya <[email protected]>
Date: 2026-09-10 (Thu, 10 Sep 2026)
Changed paths:
M DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c
Log Message:
-----------
DynamicTablesPkg: Generalize AmlLib Notify node generation
Allow AmlCodeGenNotifyNode() to attach a Notify object to any suitable
parent node.
This enables Notify objects to be generated within nested AML scopes,
for example:
Method (_EVT, 1, Serialized)
{
If (LEqual (Arg0, EventId))
{
Notify (\_SB.RAS0, Value)
}
}
Signed-off-by: Varshit Pandya <[email protected]>
Commit: 3bac5a54583d016da089f43ade85344477fd52b8
https://github.com/tianocore/edk2/commit/3bac5a54583d016da089f43ade85344477fd52b8
Author: Varshit Pandya <[email protected]>
Date: 2026-09-10 (Thu, 10 Sep 2026)
Changed paths:
M DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h
M DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c
Log Message:
-----------
DynamicTablesPkg: Add AmlLib OperationRegion code generator
Add AmlCodeGenOperationRegion() to create an AML OperationRegion
object from a region name, address space, integer offset, and integer
length.
The API creates the OperationRegion object and populates its four fixed
AML operands:
- RegionName
- RegionSpace
- RegionOffset
- RegionLength
RegionOffset and RegionLength are encoded using the smallest suitable
AML integer representation. The generated node can either be attached
directly to a supplied parent or returned to the caller for later use.
For example, the API can generate an object equivalent to:
OperationRegion (
REG0,
SystemMemory,
RegionOffset,
RegionLength
)
This provides generators with a reusable way to describe register
regions without relying on a precompiled ASL template.
Signed-off-by: Varshit Pandya <[email protected]>
Commit: 5258c715f8b7998858f082c9954e8a52e315949f
https://github.com/tianocore/edk2/commit/5258c715f8b7998858f082c9954e8a52e315949f
Author: Varshit Pandya <[email protected]>
Date: 2026-09-10 (Thu, 10 Sep 2026)
Changed paths:
M DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h
M DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c
Log Message:
-----------
DynamicTablesPkg: Add AmlLib Field code generator
Add AmlCodeGenField() to create an empty AML Field object associated
with an OperationRegion.
Expose access type, lock rule, and update rule through typed public
enumerations and encode them in the Field flags byte. The generated
Field node can be attached directly to a parent or returned so that
field elements can subsequently be appended.
For example, the API can generate:
Field (REG0, DWordAcc, NoLock, Preserve)
{
}
Signed-off-by: Varshit Pandya <[email protected]>
Commit: 007f431ff4d386229b2a3866ca1f792b09cc0577
https://github.com/tianocore/edk2/commit/007f431ff4d386229b2a3866ca1f792b09cc0577
Author: VarshitPandya <[email protected]>
Date: 2026-09-10 (Thu, 10 Sep 2026)
Changed paths:
M DynamicTablesPkg/Library/Common/AmlLib/Tree/AmlNode.c
M DynamicTablesPkg/Library/Common/AmlLib/Tree/AmlNode.h
Log Message:
-----------
DynamicTablesPkg: Validate AML package length on node creation
Validate that the package length passed to AmlCreateObjectNode() fits
within the 28-bit limit defined by the AML package-length encoding.
Perform the validation centrally so that it applies consistently to all
callers.
Signed-off-by: Varshit Pandya <[email protected]>
Commit: 26eb80185f7f5cb4522e25817061daa504d09c81
https://github.com/tianocore/edk2/commit/26eb80185f7f5cb4522e25817061daa504d09c81
Author: Varshit Pandya <[email protected]>
Date: 2026-09-10 (Thu, 10 Sep 2026)
Changed paths:
M DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h
M DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c
Log Message:
-----------
DynamicTablesPkg: Add AmlLib ReservedField code generator
Add AmlCodeGenFieldElemReserved() to create an AML ReservedField
element and append it to a Field list.
The API accepts the reserved range length in bits and validates that
the parent supports a Field list. ReservedField elements describe
unnamed gaps in Field declarations and can be used when translating
ASL Offset() declarations.
Signed-off-by: Varshit Pandya <[email protected]>
Commit: 9f68e7eff2bd9f050bb7c17eb0c75bd6aafc7737
https://github.com/tianocore/edk2/commit/9f68e7eff2bd9f050bb7c17eb0c75bd6aafc7737
Author: Varshit Pandya <[email protected]>
Date: 2026-09-10 (Thu, 10 Sep 2026)
Changed paths:
M DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h
M DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c
Log Message:
-----------
DynamicTablesPkg: Add AmlLib NamedField code generator
Add AmlCodeGenFieldElemNamed() to create a named element within an AML
Field list.
The API validates the supplied NameSeg and field length, encodes the
length using the AML FieldPkgLen format, and appends the resulting
NamedField node to its parent Field object.
Signed-off-by: Varshit Pandya <[email protected]>
Commit: c7909cba13534728a7bb832d56a83c11288beca6
https://github.com/tianocore/edk2/commit/c7909cba13534728a7bb832d56a83c11288beca6
Author: Varshit Pandya <[email protected]>
Date: 2026-09-10 (Thu, 10 Sep 2026)
Changed paths:
M DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h
M DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c
Log Message:
-----------
DynamicTablesPkg: Add AmlLib Store generator
Add AmlCodeGenStoreToName() to create an AML Store operation with a
typed source operand and a named target.
Support integer, method argument and local variable sources using the
AML_METHOD_PARAM representation. Append the generated Store node to an
optional parent object.
Signed-off-by: Varshit Pandya <[email protected]>
Commit: d9350b3219f3a7af03cd3ade4e2420ddf428bdab
https://github.com/tianocore/edk2/commit/d9350b3219f3a7af03cd3ade4e2420ddf428bdab
Author: VarshitPandya <[email protected]>
Date: 2026-09-10 (Thu, 10 Sep 2026)
Changed paths:
M DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c
Log Message:
-----------
DynamicTablesPkg: Correct AML package length calculation
Use AmlComputePkgLength() when calculating the package lengths for
Device, ThermalZone, and Scope objects.
The package-length encoding width is included in the encoded length and
can itself increase when that width is added. AmlComputePkgLength()
handles this boundary condition correctly.
Signed-off-by: Varshit Pandya <[email protected]>
Commit: d53193a9a12d282f2244ef8a6f5e53c8d1d4ad7d
https://github.com/tianocore/edk2/commit/d53193a9a12d282f2244ef8a6f5e53c8d1d4ad7d
Author: VarshitPandya <[email protected]>
Date: 2026-09-10 (Thu, 10 Sep 2026)
Changed paths:
M DynamicTablesPkg/Library/Common/AmlLib/Tree/AmlTree.c
Log Message:
-----------
DynamicTablesPkg: Validate fixed AML argument is detached
AmlSetFixedArgument() attaches NewNode to an AML object but does not
currently verify that the node is detached. Passing an already attached
node could leave the AML tree in an inconsistent state.
Require non-NULL argument nodes to be detached before attaching them.
Continue accepting NULL because callers use it to clear a fixed
argument.
Signed-off-by: Varshit Pandya <[email protected]>
Commit: 6897bef74abef88afad39075c1dad37b196e8687
https://github.com/tianocore/edk2/commit/6897bef74abef88afad39075c1dad37b196e8687
Author: Varshit Pandya <[email protected]>
Date: 2026-09-10 (Thu, 10 Sep 2026)
Changed paths:
M DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h
M DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c
Log Message:
-----------
DynamicTablesPkg: Add AmlLib If code generator
Add AmlCodeGenIf() to create an AML If object from a supplied
predicate node.
The API takes ownership of the predicate and returns an If node to
which executable statements can subsequently be appended.
Signed-off-by: Varshit Pandya <[email protected]>
Commit: f649845dc27f793b641795893e164417fd02b22f
https://github.com/tianocore/edk2/commit/f649845dc27f793b641795893e164417fd02b22f
Author: Varshit Pandya <[email protected]>
Date: 2026-09-10 (Thu, 10 Sep 2026)
Changed paths:
M DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h
M DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c
Log Message:
-----------
DynamicTablesPkg: Add AmlLib logical equality generator
Add AmlCodeGenEqual() to create an AML LEqual expression from two
supplied operands.
Use the existing AML_METHOD_PARAM representation for integer, method
argument, and local variable operands. The generated equality expression
can be used as a predicate by control-flow objects.
Signed-off-by: Varshit Pandya <[email protected]>
Compare: https://github.com/tianocore/edk2/compare/0ae702f94e12...f649845dc27f
To unsubscribe from these emails, change your notification settings at
https://github.com/tianocore/edk2/settings/notifications
_______________________________________________
edk2-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-commits
