Branch: refs/heads/master
Home: https://github.com/tianocore/edk2
Commit: 9d46dc9fa036b701f637f5e4ccc659d4999b90fd
https://github.com/tianocore/edk2/commit/9d46dc9fa036b701f637f5e4ccc659d4999b90fd
Author: Mingjie Shen <[email protected]>
Date: 2026-09-03 (Thu, 03 Sep 2026)
Changed paths:
M ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.c
Log Message:
-----------
ShellPkg/UefiShellBcfg: Exit early if ShellCommandLineParse() failed
Jump to the Done cleanup label when `ShellCommandLineParse()` fails, and move
the success path (unchanged) out of the now-unnecessary else block. This patch
does not introduce behavioral change.
Generated by the following Coccinelle semantic patch:
```smpl
@@
identifier status, problem, ret, hii;
statement S;
@@
if (EFI_ERROR (status)) {
if ((status == EFI_VOLUME_CORRUPTED) && (problem != NULL)) {
ShellPrintHiiDefaultEx (STRING_TOKEN (STR_GEN_PROBLEM), hii, ...,
problem);
FreePool (problem);
ret = SHELL_INVALID_PARAMETER;
} else {
ASSERT (FALSE);
}
+ goto Done;
}
- else {
...
- }
...
Done:
S
```
Signed-off-by: Mingjie Shen <[email protected]>
To unsubscribe from these emails, change your notification settings at
https://github.com/tianocore/edk2/settings/notifications
_______________________________________________
edk2-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-commits
