Branch: refs/heads/master
Home: https://github.com/tianocore/edk2
Commit: e8036a9fbbe4bad60e562c6641ca121280244bad
https://github.com/tianocore/edk2/commit/e8036a9fbbe4bad60e562c6641ca121280244bad
Author: Pierre Gondois <[email protected]>
Date: 2026-04-30 (Thu, 30 Apr 2026)
Changed paths:
M ShellPkg/Library/UefiShellLevel1CommandsLib/Exit.c
M ShellPkg/Library/UefiShellLevel1CommandsLib/Goto.c
M ShellPkg/Library/UefiShellLevel1CommandsLib/Stall.c
Log Message:
-----------
ShellPkg/UefiShellLevel1: Return if ShellCommandLineParse() failed
This patch aims to help breaking down the long function present in
the ShellPkg and reduce complexity/nested code and conditions.
Return directly if ShellCommandLineParse() returned an error Status.
In such case, the "Package" that should be allocated by
ShellCommandLineParse() is already freed in:
ShellCommandLineParse()
\-ShellCommandLineParseEx()
\-InternalCommandLineParse()
so there is no need to free it with ShellCommandLineFreeVarList().
No functional change should be induced by this patch.
Signed-off-by: Pierre Gondois <[email protected]>
Commit: c50e5fe946ad7b81f567d1bc662769992ff284d1
https://github.com/tianocore/edk2/commit/c50e5fe946ad7b81f567d1bc662769992ff284d1
Author: Pierre Gondois <[email protected]>
Date: 2026-04-30 (Thu, 30 Apr 2026)
Changed paths:
M ShellPkg/Library/UefiShellLevel1CommandsLib/Exit.c
M ShellPkg/Library/UefiShellLevel1CommandsLib/Goto.c
M ShellPkg/Library/UefiShellLevel1CommandsLib/Stall.c
Log Message:
-----------
ShellPkg/UefiShellLevel1: Extract MainCmdXXX() function
This patch aims to help breaking down the long function present in
the ShellPkg and reduce complexity/nested code and conditions.
Extract a MainCmdXXX() function for each shell command.
This command contains the possible operations the command aims
to operate. The ShellCommandRunXXX() function from which it
is extracted is only responsible of:
- initializing the shell/command environment
- parsing the command parameter and creating a Package
- freeing the Package
No functional change should be induced by this patch.
Signed-off-by: Pierre Gondois <[email protected]>
Commit: c801f959bba919d44a189b274690bca804fdf9c0
https://github.com/tianocore/edk2/commit/c801f959bba919d44a189b274690bca804fdf9c0
Author: Pierre Gondois <[email protected]>
Date: 2026-04-30 (Thu, 30 Apr 2026)
Changed paths:
M ShellPkg/Library/UefiShellLevel1CommandsLib/Exit.c
M ShellPkg/Library/UefiShellLevel1CommandsLib/Goto.c
M ShellPkg/Library/UefiShellLevel1CommandsLib/Stall.c
Log Message:
-----------
ShellPkg/UefiShellLevel1: Lower indentation level in MainCmdXXX()
This patch aims to help breaking down the long function present in
the ShellPkg and reduce complexity/nested code and conditions.
Lower the indentation level in the newly created MainCmdXXX()
functions.
Remove the ShellStatus variable which is not necessary.
No functional change should be induced by this patch.
Signed-off-by: Pierre Gondois <[email protected]>
Compare: https://github.com/tianocore/edk2/compare/d8b163508842...c801f959bba9
To unsubscribe from these emails, change your notification settings at
https://github.com/tianocore/edk2/settings/notifications
_______________________________________________
edk2-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-commits
