Branch: refs/heads/master
Home: https://github.com/tianocore/edk2
Commit: be4fc071eb01c7420707e887c92a3adf3e07ea72
https://github.com/tianocore/edk2/commit/be4fc071eb01c7420707e887c92a3adf3e07ea72
Author: Oliver Smith-Denny <[email protected]>
Date: 2026-04-21 (Tue, 21 Apr 2026)
Changed paths:
M BaseTools/Source/Python/Common/ToolDefClassObject.py
Log Message:
-----------
BaseTools: Reject Inline Comments in tools_def
There is a bug in BaseTools currently when an inline
comment is used in tools_def. The comment is not
stripped out and wreaks havoc down the line,
causing BaseTools to get confused elsewhere and
drop build options it should be applying.
This fixes that behavior by following the build spec
which states:
Comments are only allows on separate lines and may not
be appended appear on actual entry lines.
Inline comments are now not allowed and the build will
fail and specify why and where.
Signed-off-by: Oliver Smith-Denny <[email protected]>
To unsubscribe from these emails, change your notification settings at
https://github.com/tianocore/edk2/settings/notifications
_______________________________________________
edk2-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-commits
