Branch: refs/heads/master
Home: https://github.com/tianocore/edk2
Commit: 38c4cd4e88adf6d5d5c4bf753dafba7f24f019d0
https://github.com/tianocore/edk2/commit/38c4cd4e88adf6d5d5c4bf753dafba7f24f019d0
Author: Michael Kubacki <[email protected]>
Date: 2024-08-05 (Mon, 05 Aug 2024)
Changed paths:
M .github/workflows/request-reviews.yml
Log Message:
-----------
.github/request-reviews.yml: Use sparse checkout
Optimizes the repository checkout step from an average time of 21
to 1 second by performing a sparse checkout of only the file paths
needed for the workflow run at a fetch depth of 1.
Signed-off-by: Michael Kubacki <[email protected]>
Commit: 057c26710a1f1daf68c00a72180963191d49953d
https://github.com/tianocore/edk2/commit/057c26710a1f1daf68c00a72180963191d49953d
Author: Michael Kubacki <[email protected]>
Date: 2024-08-05 (Mon, 05 Aug 2024)
Changed paths:
A .github/scripts/requirements.txt
M .github/workflows/request-reviews.yml
Log Message:
-----------
.github/request-reviews.yml: Cache PIP modules
- Optimizes and makes the PIP module installation process for the
workflow more robust by caching the pip modules used so the only
time the workflow needs to reach to PyPi is when new PIP modules
are published.
- Improves long term stability by locking the major versions for PIP
modules in the workflow. This is to reduce overall maintenance over
time to automatically pick up new versions while also not being
broken in the process.
- Removes edk2-pytool-extensions as it is not used.
The new "requirements.txt" file is used to lock versions and support
the caching step which depends on a requirements file.
Signed-off-by: Michael Kubacki <[email protected]>
Commit: 98f17cdcf41df331ac3cdd4be0686219fa812b7f
https://github.com/tianocore/edk2/commit/98f17cdcf41df331ac3cdd4be0686219fa812b7f
Author: Michael Kubacki <[email protected]>
Date: 2024-08-05 (Mon, 05 Aug 2024)
Changed paths:
M .github/scripts/GitHub.py
M .github/scripts/requirements.txt
M .github/workflows/request-reviews.yml
Log Message:
-----------
.github/request-reviews.yml: Switch to GitPython
Uses `GitPython` instead of invoking the git executable directly.
This has the benefit of improving code readability and less support
code for binary interaction.
Signed-off-by: Michael Kubacki <[email protected]>
Commit: d3e9e1077059e8f565daae31811fe3f0d245fb17
https://github.com/tianocore/edk2/commit/d3e9e1077059e8f565daae31811fe3f0d245fb17
Author: Michael Kubacki <[email protected]>
Date: 2024-08-05 (Mon, 05 Aug 2024)
Changed paths:
M .github/scripts/GitHub.py
M .github/scripts/requirements.txt
M .github/workflows/request-reviews.yml
Log Message:
-----------
.github/request-reviews.yml: Switch to PyGithub
Uses PyGithub for GitHub interactions instead of the GitHub REST API
directly.
This simplifies the code, improves error handling and robustness, and
lets the PyGithub project abstract GitHub REST API changes that may
occur over time.
Signed-off-by: Michael Kubacki <[email protected]>
Commit: eaf2b82eda199260022504a1a0f7966b0dd56944
https://github.com/tianocore/edk2/commit/eaf2b82eda199260022504a1a0f7966b0dd56944
Author: Michael Kubacki <[email protected]>
Date: 2024-08-05 (Mon, 05 Aug 2024)
Changed paths:
M .github/scripts/GitHub.py
M .github/scripts/requirements.txt
Log Message:
-----------
.github/request-reviews.yml: Removed unused functionality
Removed the `download_gh_file()` function which is no longer needed
with sparse checkout.
Signed-off-by: Michael Kubacki <[email protected]>
Commit: e86647decda974aff8a4356f67adc730eddea111
https://github.com/tianocore/edk2/commit/e86647decda974aff8a4356f67adc730eddea111
Author: Michael Kubacki <[email protected]>
Date: 2024-08-05 (Mon, 05 Aug 2024)
Changed paths:
M .github/scripts/GitHub.py
M .github/workflows/request-reviews.yml
Log Message:
-----------
.github/request-reviews.yml: Update PR reviewer exclusion
Updates logic to:
- Not request reviews from reviewers that have already left a review
on the PR. Previously, the reviewers review (e.g. approval) would
remain on the PR, but they would be notified on each change to the
PR. This approach follows the expected notification process for
requesting reviews which is one time. Maintainers and reviewers can
set up their own notifications for more granular updates on PR
activity separately.
- Add the collaborator reviewers if a reviewer(s) is found to not be
a collaborator. This is an improvement to today's behavior which is
to not add any reviewers if a single reviewer is not a collaborator
of the repo.
Signed-off-by: Michael Kubacki <[email protected]>
Commit: 09ad1a00729d53ba06e7f441eefc6fa364b10059
https://github.com/tianocore/edk2/commit/09ad1a00729d53ba06e7f441eefc6fa364b10059
Author: Michael Kubacki <[email protected]>
Date: 2024-08-05 (Mon, 05 Aug 2024)
Changed paths:
M .github/scripts/GitHub.py
Log Message:
-----------
.github/request-reviews.yml: Add non-collab admin notification
If a non-collaborator is part of the reviewer list, an admin needs
to be notified so they can be removed.
This change finds the list of admins for the repo and notifies them
in the comment left on the PR describing the list of non-collaborator
users. The message itself is cleaned up to show only the
non-collaborator users for ease of identification.
Signed-off-by: Michael Kubacki <[email protected]>
Commit: f617b6ee0eb81853b50fd50ea71dd1b2ceb9b9a5
https://github.com/tianocore/edk2/commit/f617b6ee0eb81853b50fd50ea71dd1b2ceb9b9a5
Author: Michael Kubacki <[email protected]>
Date: 2024-08-05 (Mon, 05 Aug 2024)
Changed paths:
M .github/scripts/GitHub.py
Log Message:
-----------
.github/request-reviews.yml: Only post non-collab message once
Enhances the flow that adds a comment on a PR if a non-collaborator
is in the reviewer list by checking if a comment was previously left
on the PR. If it was for the same set of non-collaborators, another
comment is not created. If a new non-collaborator is discovered, the
message will be left identifying that new user account.
Signed-off-by: Michael Kubacki <[email protected]>
Commit: 32a099c358b3d4b093f76b2d060bcb3154ac5c56
https://github.com/tianocore/edk2/commit/32a099c358b3d4b093f76b2d060bcb3154ac5c56
Author: Michael Kubacki <[email protected]>
Date: 2024-08-05 (Mon, 05 Aug 2024)
Changed paths:
M .github/scripts/GitHub.py
M .github/workflows/request-reviews.yml
Log Message:
-----------
.github/request-reviews.yml: Improve doc and dbg messages
Adds additional documentation and cleans up debug messages printed
to GitHub workflow output (available in the GitHub Actions pane).
Signed-off-by: Michael Kubacki <[email protected]>
Commit: 59ad8aeda6352e5da12aaab08ede719ac3a832e5
https://github.com/tianocore/edk2/commit/59ad8aeda6352e5da12aaab08ede719ac3a832e5
Author: Michael Kubacki <[email protected]>
Date: 2024-08-05 (Mon, 05 Aug 2024)
Changed paths:
M .github/scripts/GitHub.py
M .github/workflows/request-reviews.yml
Log Message:
-----------
.github/request-reviews.yml: Formatting (non-functional)
Updates code for PEP8 formatting by using the Black code formatter.
Signed-off-by: Michael Kubacki <[email protected]>
Commit: 51ada84cd57c5ef6c75a72aeb002226cf9180b21
https://github.com/tianocore/edk2/commit/51ada84cd57c5ef6c75a72aeb002226cf9180b21
Author: Michael Kubacki <[email protected]>
Date: 2024-08-05 (Mon, 05 Aug 2024)
Changed paths:
A .github/scripts/RequestPrReviewers.py
M .github/workflows/request-reviews.yml
Log Message:
-----------
.github/request-reviews.yml: Move workflow Py code to file
To make the Python code used within the action more mantainable over
time, it is moved to a standalone script in .github/scripts.
No functional changes are made to the workflow itself.
Signed-off-by: Michael Kubacki <[email protected]>
Compare: https://github.com/tianocore/edk2/compare/5d43165ff859...51ada84cd57c
To unsubscribe from these emails, change your notification settings at
https://github.com/tianocore/edk2/settings/notifications
_______________________________________________
edk2-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-commits