On Thu, Apr 02, 2020 at 11:27:45AM +0300, Dan Carpenter wrote: > I don't know how this patch made it through two versions without anyone > complaining that this paragraph should be done as a separate patch...
I often fold comment (and spacing/formatting) patches in to a main patch, when touching adjacent code anyway and it doesn't cause distracting clutter. This seemed like such a case, which is why I submitted it as one. But it's a bit of style thing. >> Cc: Adham Abozaeid <[email protected]> >> Cc: [email protected] >> Reviewed-by: Ajay Singh <[email protected]> >> Signed-off-by: George Spelvin <[email protected]> >> --- > > This should have you Signed-off-by. The Reviewed-by is kind of assumed > so you can drop that bit. But everyone who touches a patch needs to > add their signed off by. Er... all he did was add "staging: " to the front of the title. That's not a change to the code at all, and as trivial a change to the commit message as adding "Reviewed-by:" to the end. We don't need S-o-b for such things or we'd end up in a horrible infinite recursion. _______________________________________________ devel mailing list [email protected] http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
