On Tue, Feb 04, 2020 at 08:06:14PM +0000, Chris Packham wrote: > On Tue, 2020-02-04 at 07:09 +0000, [email protected] wrote: > > On Tue, Feb 04, 2020 at 04:02:15AM +0000, Chris Packham wrote: > > > I'll pipe up on this thread too > > > > > > On Tue, 2019-12-10 at 02:42 -0800, Guenter Roeck wrote: > > > > On 12/10/19 1:15 AM, Greg Kroah-Hartman wrote: > > > > > This driver has been in the tree since 2009 with no real movement to > > > > > get > > > > > it out. Now it is starting to cause build issues and other problems > > > > > for > > > > > people who want to fix coding style problems, but can not actually > > > > > build > > > > > it. > > > > > > > > > > As nothing is happening here, just delete the module entirely. > > > > > > > > > > Reported-by: Guenter Roeck <[email protected]> > > > > > Cc: David Daney <[email protected]> > > > > > Cc: "David S. Miller" <[email protected]> > > > > > Cc: "Matthew Wilcox (Oracle)" <[email protected]> > > > > > Cc: Guenter Roeck <[email protected]> > > > > > Cc: YueHaibing <[email protected]> > > > > > Cc: Aaro Koskinen <[email protected]> > > > > > Cc: Wambui Karuga <[email protected]> > > > > > Cc: Julia Lawall <[email protected]> > > > > > Cc: Florian Westphal <[email protected]> > > > > > Cc: Geert Uytterhoeven <[email protected]> > > > > > Cc: Branden Bonaby <[email protected]> > > > > > Cc: "Petr Štetiar" <[email protected]> > > > > > Cc: Sandro Volery <[email protected]> > > > > > Cc: Paul Burton <[email protected]> > > > > > Cc: Dan Carpenter <[email protected]> > > > > > Cc: Giovanni Gherdovich <[email protected]> > > > > > Cc: Valery Ivanov <[email protected]> > > > > > Signed-off-by: Greg Kroah-Hartman <[email protected]> > > > > > > > > Acked-by: Guenter Roeck <[email protected]> > > > > > > Please can we keep this driver. We do have platforms using it and we > > > would like it to stay around. > > > > > > Clearly we'll need to sort things out to a point where they build > > > successfully. We've been hoping to see this move out of staging ever > > > since we selected Cavium as a vendor. > > > > Great, can you send me a patchset that reverts this and fixes the build > > issues and accept maintainership of the code? > > > > Yep will do. > > On Tue, 2020-02-04 at 10:21 +0300, Dan Carpenter wrote: > > My advice is to delete all the COMPILE_TEST code. That stuff was a > > constant source of confusion and headaches. > > I was also going to suggest this. Since the COMPILE_TEST has been a > source of trouble I was going to propose dropping the || COMPILE_TEST > from the Kconfig for the octeon drivers.
It isn't just the Kconfig file, there is also a lot of actual _code_ that depends on COMPILE_TEST. Guenter _______________________________________________ devel mailing list [email protected] http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
