On Mon, Nov 11, 2019 at 12:14:24PM -0500, Marcelo Diop-Gonzalez wrote:
> @@ -109,7 +108,8 @@ int vchiq_platform_init(struct platform_device *pdev,
> struct vchiq_state *state)
> if (err < 0)
> return err;
>
> - g_cache_line_size = drvdata->cache_line_size;
> + if (of_device_is_compatible(dev->of_node, "brcm,bcm2836-vchiq"))
> + g_cache_line_size = 64;
Could you remove the initialization and do it like this:
if (of_device_is_compatible(dev->of_node, "brcm,bcm2836-vchiq"))
g_cache_line_size = 64;
else
g_cache_line_size = 32;
Maybe we could even just remove the global?
regards,
dan carpenter
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
