> -----Original Message-----
> From: Guenter Roeck <[email protected]> On Behalf Of Guenter Roeck
> Sent: Dienstag, 12. November 2019 20:18
> To: Jonathan Cameron <[email protected]>
> Cc: Bia, Beniamin <[email protected]>; [email protected];
> [email protected]; Hennerich, Michael <[email protected]>;
> [email protected]; [email protected]; linux-
> [email protected]; [email protected]; linux-
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected]; Jean Delvare
> <[email protected]>
> Subject: Re: [PATCH 1/3] iio: Add ADM1177 Hot Swap Controller and Digital
> Power Monitor driver
>
> On Tue, Nov 12, 2019 at 05:37:57PM +0000, Jonathan Cameron wrote:
> > On Tue, 12 Nov 2019 17:35:50 +0200
> > Beniamin Bia <[email protected]> wrote:
> >
> > > From: Michael Hennerich <[email protected]>
> > >
> > > ADM1177 is a Hot Swap Controller and Digital Power Monitor with Soft
> > > Start Pin.
> > >
> > > Datasheet:
> > > Link:
> > > https://www.analog.com/media/en/technical-documentation/data-
> sheets/
> > > ADM1177.pdf
> > >
> > > Signed-off-by: Michael Hennerich <[email protected]>
> > > Co-developed-by: Beniamin Bia <[email protected]>
> > > Signed-off-by: Beniamin Bia <[email protected]>
> >
> > Hi Beniamin,
> >
> > A couple immediate thoughts.
> >
> > 1. That cc list has some rather non obvious people on it. Unless something
> > fairly surprising is going on, probably better to cut it back a bit.
> >
> > 2. Why IIO? Not entirely obvious to me. From first glance this is
> > definitely
> > doing hardware monitoring. If there is a reason there should be a clear
> > statement here on why.
> >
>
> I don't see why this is implemented as iio driver. I think it should be
> implemented as hardware monitoring driver.
Totally agree that this driver could have been implemented as HWMON driver.
Well we use this device as USB supply monitor on our embedded portably kits, to
detect low VBUS or excess current draw.
ADALM-PLUTO and ADALM2000:
https://www.analog.com/en/design-center/evaluation-hardware-and-software/evaluation-boards-kits/adalm-pluto.html
https://www.analog.com/en/design-center/evaluation-hardware-and-software/evaluation-boards-kits/ADALM2000.html
The only connectivity to the host PC is via IIO/libiio USB Gadget FS and
Ethernet backends.
We recommend people to read the IIO attributes whenever they report an issue.
Unless libiio supports directly HWMON or HWMON adds an IIO bridge we would
prefer this driver being exposed as IIO device, since HWMON users still can use
the IIO/HWMON bridge.
-Michael
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
