On Tue, Oct 08, 2019 at 01:38:57PM +0800, zhengbin wrote:
> diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c
> b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c
> index c6f9cf1..8a94c5b 100644
> --- a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c
> +++ b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c
> @@ -96,13 +96,12 @@ static void audio_vchi_callback(void *param,
> struct bcm2835_audio_instance *instance = param;
> struct vc_audio_msg m;
> int msg_len;
> - int status;
>
> if (reason != VCHI_CALLBACK_MSG_AVAILABLE)
> return;
>
> - status = vchi_msg_dequeue(instance->vchi_handle,
> - &m, sizeof(m), &msg_len, VCHI_FLAGS_NONE);
> + vchi_msg_dequeue(instance->vchi_handle,
> + &m, sizeof(m), &msg_len, VCHI_FLAGS_NONE);
This looks like a bug in the code. flags is VCHI_FLAGS_NONE so it can
return -1 and we should check for that.
> if (m.type == VC_AUDIO_MSG_TYPE_RESULT) {
regards,
dan carpenter
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
