This bitwisen / boolean expression can be made more readable while
reducing the line lengths at the same time. This commit uses the
fact that
a & (b | c) == (b | c)
evaluates to true if and only if
(a & b) && (a & c)
is true. Since b and c are constants with relatively long names,
using the second form makes the code much more readable and shorter.
Signed-off-by: Tobias Nießen <[email protected]>
Signed-off-by: Sabrina Gaube <[email protected]>
---
drivers/staging/rts5208/xd.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rts5208/xd.c b/drivers/staging/rts5208/xd.c
index c5ee04ecd1c9..f3dc96a4c59d 100644
--- a/drivers/staging/rts5208/xd.c
+++ b/drivers/staging/rts5208/xd.c
@@ -1155,10 +1155,10 @@ static int xd_copy_page(struct rtsx_chip *chip, u32
old_blk, u32 new_blk,
return STATUS_FAIL;
}
- if (((reg & (XD_ECC1_ERROR |
XD_ECC1_UNCORRECTABLE)) ==
- (XD_ECC1_ERROR |
XD_ECC1_UNCORRECTABLE)) ||
- ((reg & (XD_ECC2_ERROR |
XD_ECC2_UNCORRECTABLE)) ==
- (XD_ECC2_ERROR |
XD_ECC2_UNCORRECTABLE))) {
+ if (((reg & XD_ECC1_ERROR) &&
+ (reg & XD_ECC1_UNCORRECTABLE)) ||
+ ((reg & XD_ECC2_ERROR) &&
+ (reg & XD_ECC2_UNCORRECTABLE))) {
rtsx_write_register(chip,
XD_PAGE_STATUS,
0xFF,
--
2.17.0
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
