>-----Original Message-----
>From: devel <[email protected]> On Behalf Of
>Define separate simple show functions for each attribute instead of having a
>one big one containing a chain of conditionals.
>
>+static ssize_t s2c_dma_ch_show(struct device *dev,
>+                              struct device_attribute *attr, char *buf)
>+{
>+       return 0;
>+}
>+
>+static ssize_t c2s_dma_ch_show(struct device *dev,
>+                              struct device_attribute *attr, char *buf)
>+{
>+       return 0;
>+}

These two can be removed.  Technically, that would be a userspace-breaking
change, but I can guarantee that all existing userspace consumers don't actually
read that sysfs node.
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to