> -----Original Message----- > From: David Laight <[email protected]> > Sent: Wednesday, 10 April 2019 6:45 PM > To: 'Alastair D'Silva' <[email protected]>; [email protected] > Cc: Jani Nikula <[email protected]>; Joonas Lahtinen > <[email protected]>; Rodrigo Vivi <[email protected]>; > David Airlie <[email protected]>; Daniel Vetter <[email protected]>; Karsten Keil > <[email protected]>; Jassi Brar <[email protected]>; Tom Lendacky > <[email protected]>; David S. Miller <[email protected]>; > Jose Abreu <[email protected]>; Kalle Valo > <[email protected]>; Stanislaw Gruszka <[email protected]>; > Benson Leung <[email protected]>; Enric Balletbo i Serra > <[email protected]>; James E.J. Bottomley > <[email protected]>; Martin K. Petersen <[email protected]>; > Greg Kroah-Hartman <[email protected]>; Alexander Viro > <[email protected]>; Petr Mladek <[email protected]>; Sergey > Senozhatsky <[email protected]>; Steven Rostedt > <[email protected]>; Andrew Morton <[email protected]>; > [email protected]; [email protected]; linux- > [email protected]; [email protected]; > [email protected]; [email protected]; linux- > [email protected]; [email protected]; > [email protected]; [email protected] > Subject: RE: [PATCH 4/4] lib/hexdump.c: Allow multiple groups to be > separated by lines '|' > > From: Alastair D'Silva > > Sent: 10 April 2019 04:17 > > With the wider display format, it can become hard to identify how many > > bytes into the line you are looking at. > > > > The patch adds new flags to hex_dump_to_buffer() and > print_hex_dump() > > to print vertical lines to separate every N groups of bytes. > > > > eg. > > buf:00000000: 454d414e 43415053|4e495f45 00584544 > NAMESPAC|E_INDEX. > > buf:00000010: 00000000 00000002|00000000 00000000 ........|........ > > Ugg, that is just horrid. > It is enough to add an extra space if you really need the columns to be more > easily counted. >
I did consider that, but it would be a more invasive change, as the buffer length required would differ based on the flags. > I'm not even sure that is needed if you are printing 32bit words. > OTOH 32bit words makes 64bit values really stupid on LE systems. > Bytes with extra spaces every 4 bytes is the format I prefer even for long > lines. > > Oh, and if you are using hexdump() a lot you want a version that never uses > snprintf(). > > David > > - > Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, > MK1 1PT, UK Registration No: 1397386 (Wales) > > > --- > This email has been checked for viruses by AVG. > https://www.avg.com _______________________________________________ devel mailing list [email protected] http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
