On 17/12/2018 20:51, Alexander Schroth wrote:
According to the Linux coding guidelines, defines should be written
in uppercase. This patch converts all define-statements in the
ni_pcidio.c file to uppercase, thus matching the coding style of the
kernel.
Signed-off-by: Alexander Schroth <[email protected]>
Signed-off-by: Marco Ammon <[email protected]>
---
Minor quibble: There should be a description of the 'v2' changes here
(after the '---' line).
Also, the patch "Subject:" line is missing the "staging:" tag. The
usual set of tags for patches to this driver is "staging: comedi:
ni_pcidio:".
Apart from that, the patch seems fine.
Reviewed-by: Ian Abbott <[email protected]>
drivers/staging/comedi/drivers/ni_pcidio.c | 442 +++++++++++----------
1 file changed, 222 insertions(+), 220 deletions(-)
--
-=( Ian Abbott <[email protected]> || Web: www.mev.co.uk )=-
-=( MEV Ltd. is a company registered in England & Wales. )=-
-=( Registered number: 02862268. Registered address: )=-
-=( 15 West Park Road, Bramhall, STOCKPORT, SK7 3JZ, UK. )=-
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
