On Tue, Dec 11, 2018 at 07:31:00PM +0100, Dominic Braun wrote:
> Typedefing structs is not encouraged in the kernel.
>
> The removal of typedefs was requested in interface/vchi/TODO in commit
> 7626e002225a4c1b9455689b1f22909dfeff43ca.
When you mention a commit then use this format:
"requested in interface/vchi/TODO in commit 7626e002225a ("staging:
vchiq: add more tasks to the TODO list")"
But really the sentence doesn't add anything. Removing typedefs is
a kernel wide thing, not a driver specific requirement.
>
> Signed-off-by: Dominic Braun <[email protected]>
> Signed-off-by: Tobias Büttner <[email protected]>
> ---
> .../interface/vchiq_arm/vchiq_2835_arm.c | 2 +-
> .../vc04_services/interface/vchiq_arm/vchiq_core.c | 9 +++++----
> .../vc04_services/interface/vchiq_arm/vchiq_core.h | 14 +++++++-------
> 3 files changed, 13 insertions(+), 12 deletions(-)
>
> diff --git
> a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c
> b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c
> index 5601d167ac60..76e87cda130c 100644
> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c
> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c
> @@ -234,7 +234,7 @@ vchiq_platform_get_arm_state(VCHIQ_STATE_T *state)
> }
>
> void
> -remote_event_signal(REMOTE_EVENT_T *event)
> +remote_event_signal(struct remote_event_struct *event)
^^^^^^^
The struct on the end of this name is redundant. Maybe name it
something based on what type of remote event it is like
vc04_remote_event? I don't know. To me just remote_event is fine also.
regards,
dan carpenter
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
