On Mon, Jul 16, 2018 at 07:09:11PM -0700, Todd Poynor wrote:
> @@ -629,7 +630,6 @@ static bool is_gcb_in_reset(struct gasket_dev *gasket_dev)
> */
> static uint apex_ioctl_check_permissions(struct file *filp, uint cmd)
> {
> - struct gasket_dev *gasket_dev = filp->private_data;
> fmode_t write;
>
> write = filp->f_mode & FMODE_WRITE;
This should have gone in the earlier patch. When you spot something
like that then create a separate patch for it and use `git rebase -i` to
fold it back into the original.
regards,
dan carpenter
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
