From: Todd Poynor <[email protected]> class_create() never returns NULL, and this driver should never return PTR_ERR(NULL) anyway.
Reported-by: Dmitry Torokhov <[email protected]> Signed-off-by: Zhongze Hu <[email protected]> Signed-off-by: Todd Poynor <[email protected]> Reviewed-by: Dmitry Torokhov <[email protected]> --- drivers/staging/gasket/gasket_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gasket/gasket_core.c b/drivers/staging/gasket/gasket_core.c index 07c6fa3623f77..7ea6551626524 100644 --- a/drivers/staging/gasket/gasket_core.c +++ b/drivers/staging/gasket/gasket_core.c @@ -322,7 +322,7 @@ int gasket_register_device(const struct gasket_driver_desc *driver_desc) internal->class = class_create(driver_desc->module, driver_desc->name); - if (IS_ERR_OR_NULL(internal->class)) { + if (IS_ERR(internal->class)) { gasket_nodev_error("Cannot register %s class [ret=%ld]", driver_desc->name, PTR_ERR(internal->class)); ret = PTR_ERR(internal->class); -- 2.18.0.203.gfac676dfb9-goog _______________________________________________ devel mailing list [email protected] http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
