This function only has one caller so mask_width is 1 and mask_shift is
32. Shifting an int by 32 bits is undefined, but I guess on GCC it
wraps to 0x1? Anyway it's supposed to be 0x100000000.
Fixes: 9a69f5087ccc ("drivers/staging: Gasket driver framework + Apex driver")
Signed-off-by: Dan Carpenter <[email protected]>
diff --git a/drivers/staging/gasket/gasket_core.h
b/drivers/staging/gasket/gasket_core.h
index 203b9a31377b..5d6535a0f254 100644
--- a/drivers/staging/gasket/gasket_core.h
+++ b/drivers/staging/gasket/gasket_core.h
@@ -683,7 +683,7 @@ static inline void gasket_read_modify_write_64(
u64 mask, tmp;
tmp = gasket_dev_read_64(dev, bar, location);
- mask = ((1 << mask_width) - 1) << mask_shift;
+ mask = ((1ULL << mask_width) - 1) << mask_shift;
tmp = (tmp & ~mask) | (value << mask_shift);
gasket_dev_write_64(dev, tmp, bar, location);
}
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
