On Wed, May 16, 2018 at 07:30:01AM +0200, Sergio Paracuellos wrote:
> diff --git a/drivers/staging/mt7621-gpio/gpio-mt7621.c
> b/drivers/staging/mt7621-gpio/gpio-mt7621.c
> index c701259..2d16d62 100644
> --- a/drivers/staging/mt7621-gpio/gpio-mt7621.c
> +++ b/drivers/staging/mt7621-gpio/gpio-mt7621.c
> @@ -156,17 +156,18 @@ mediatek_gpio_bank_probe(struct platform_device *pdev,
> struct device_node *bank)
> {
> struct mtk_data *gpio_data = dev_get_drvdata(&pdev->dev);
> const __be32 *id = of_get_property(bank, "reg", NULL);
> - struct mtk_gc *rg = devm_kzalloc(&pdev->dev,
> - sizeof(struct mtk_gc), GFP_KERNEL);
> + struct mtk_gc *rg;
> int ret;
>
> - if (!rg || !id || be32_to_cpu(*id) > MTK_MAX_BANK)
> + if (!id || be32_to_cpu(*id) > MTK_MAX_BANK)
You didn't introduce this, but it should be >= MTK_MAX_BANK. (Off by
one).
regards,
dan carpenter
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
