> -----Original Message----- > From: Dan Carpenter <[email protected]> > Sent: Thursday, April 26, 2018 2:32 PM > To: KY Srinivasan <[email protected]> > Cc: [email protected]; [email protected]; linux- > [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected]; Stephen Hemminger <[email protected]>; Michael > Kelley (EOSG) <[email protected]>; [email protected] > Subject: Re: [PATCH 2/5] X86: Hyper-V: Enable IPI enlightenments > > On Wed, Apr 25, 2018 at 11:12:47AM -0700, [email protected] wrote: > > +/* > > + * IPI implementation on Hyper-V. > > + */ > > + > > +static int __send_ipi_mask(const struct cpumask *mask, int vector) > > +{ > > + int cur_cpu, vcpu; > > + struct ipi_arg_non_ex **arg; > > + struct ipi_arg_non_ex *ipi_arg; > > + int ret = 1; > > Not specifically related to this patch, but hv code sometimes returns 1 > on error or U64_MAX. It's slightly magical. Maybe > HV_STATUS_INVALID_HYPERCALL_INPUT (3) would be more appropriate? > Or we > could make a new more generic error code: > > #define HV_STATUS_INVALID 1
Good point. We will look at cleaning this up. Regards, K. Y _______________________________________________ devel mailing list [email protected] http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
